Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toki #553

Closed
wants to merge 1 commit into from
Closed

Remove toki #553

wants to merge 1 commit into from

Conversation

mbells
Copy link

@mbells mbells commented Sep 24, 2024

Remove the toki module, replaced with a rewritten tokre. This is a tokenizer based on regular expressions.
The API is similar, but not the same.
The tokre module is pulled into the same repo, as there are not many users of the original code.
Fixes issue #551

Remove the toki module, replaced with a rewritten tokre.
This is a tokenizer based on regular expressions.
The API is similar, but not the same.
The tokre module is pulled into the same repo, as there are
not many users of the original code.
Fixes issue grafana#551
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@npazosmendez
Copy link
Contributor

Thank you for working on this and sorry for the delay on our end. We had an internal discussion about how to proceed about this. Fortunately, toki's maintainer just added an MIT license to the project, which I believe resolves your concern: taylorchu/toki@36c157a

Having that said, I will close this PR.

@mbells
Copy link
Author

mbells commented Oct 1, 2024

Thanks. We're more than happy that it was resolved by updating the license of the original package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants