Fix Grafana Configuration for Unified and Legacy Alerting Based on Version #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please review - @gardar |
ishanjainn
approved these changes
Jun 25, 2024
zhan9san
reviewed
Jun 26, 2024
|
Hello guys ! Any news about this PR ? |
|
Hello ! Also interested in this PR. It is possible to review ? Thanks |
|
@ishanjainn Do you think we can merge it? |
|
Ill make this part of the next release (Will be released on Monday) |
|
Hello, is it possible to release a new version of the collection ? |
kysrpex
added a commit
to usegalaxy-eu/infrastructure-playbook
that referenced
this pull request
Jul 25, 2024
Upgrade `grafana.grafana` from git+https://github.com/usegalaxy-eu/ansible-grafana-collection-grafana.git/,cc9f61c0ae30c12eecf2af4696d95a84ea4565e1 (usegalaxy-eu/ansible-grafana-collection fork) to latest official release (reason for change usegalaxy-eu/issues#558 (comment)). Please note that, although it is not a problem because we are not using them anymore, this involves tasks "Import grafana dashboards via api" breaking again and "Ensure datasources exist (via API)" not taking UIDs anymore. Version 5.3.0 fixed the role `grafana.grafana.grafana` not populating the `[unified_alerting]` section of grafana.ini (grafana/grafana-ansible-collection#215). Therefore, remove the post_task from the grafana.yml playbook that worked the issue around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where the
[alerting]section was incorrectly templated for Grafana versionsv11and higher, causing failures in Grafana deployments.Changes
[unified_alerting]and[alerting]sections based on the Grafana version.[unified_alerting]section is included whengrafana_versionislatestorv11and higher.[alerting]section is included only for versions belowv11.Testing
[unified_alerting]section is correctly templated for versionslatestandv11+.[alerting]section is correctly templated for versions belowv11.Notes
v11and maintains support for legacy alerting mechanisms in older versions.