Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki-distributed] Update service templates as per Grafana documentation #2885

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Sheikh-Abubaker
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker commented Jan 7, 2024

Fixes #2818

zanhsieh and others added 25 commits January 11, 2024 00:27
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
@Sheikh-Abubaker Sheikh-Abubaker changed the title [loki-distributed] Updated service templates as per Grafana documentation [loki-distributed] Update service templates as per Grafana documentation Jun 8, 2024
@zanhsieh
Copy link
Collaborator

@zalegrala Little help on this PR please.

@zanhsieh
Copy link
Collaborator

@jkroepke Can you review this PR please?

@jkroepke
Copy link
Collaborator

jkroepke commented Jul 30, 2024

I have no idea here, and I don't know if its safe to omit 9096.

appProtocol is introduced in Kubernetes 1.20, the minimum Kubernetes version should be raised and defined in Chart.yaml

In general, I asking myself why this chart is still maintained. I would recommend to deprecated (and remove) this chart, since loki maintainers itself maintains the loki chart in the own repository.

@Sheikh-Abubaker
Copy link
Collaborator Author

@zanhsieh This is a very old PR of mine, meanwhile I didn't get much time looking back at this PR, I think for now I'd convert it into a draft and when I am sure of all the changes I'll reopen it.

@Sheikh-Abubaker
Copy link
Collaborator Author

In general, I asking myself why this chart is still maintained. I would recommend to deprecated (and remove) this chart, since loki maintainers itself maintains the loki chart in the own repository.

I'm also thinking the same!

@Sheikh-Abubaker Sheikh-Abubaker marked this pull request as draft July 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[loki-distributed] deploying on istio throws Istio Warning
3 participants