-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loki-distributed] Update service templates as per Grafana documentation #2885
base: main
Are you sure you want to change the base?
Conversation
… enabled Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
@zalegrala Little help on this PR please. |
@jkroepke Can you review this PR please? |
I have no idea here, and I don't know if its safe to omit 9096. appProtocol is introduced in Kubernetes 1.20, the minimum Kubernetes version should be raised and defined in Chart.yaml In general, I asking myself why this chart is still maintained. I would recommend to deprecated (and remove) this chart, since loki maintainers itself maintains the loki chart in the own repository. |
@zanhsieh This is a very old PR of mine, meanwhile I didn't get much time looking back at this PR, I think for now I'd convert it into a draft and when I am sure of all the changes I'll reopen it. |
I'm also thinking the same! |
Fixes #2818