[loki-distributed] fix hpa selector #3052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gritzko Daniel Kleiner <[email protected]>
zanhsieh
changed the title
Signed-off-by: Gritzko Daniel Kleiner <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
zanhsieh
approved these changes
May 1, 2024
Signed-off-by: Gritzko Daniel Kleiner <[email protected]>
…istributed-hpa-selector Signed-off-by: Gritzko Daniel Kleiner <[email protected]>
Signed-off-by: Gritzko Daniel Kleiner <[email protected]>
Signed-off-by: Gritzko Daniel Kleiner <[email protected]>
|
@Whyeasy @unguiculu 👀 🙏🏻 |
|
@zalegrala Please help. |
zalegrala
reviewed
Jun 7, 2024
| {{- end -}} | ||
| {{- if .Capabilities.APIVersions.Has "autoscaling/v2" }} | ||
| {{- print "autoscaling/v2" }} | ||
| {{- else }} |
There was a problem hiding this comment.
Should we check for autoscaling/v2beta2 and autoscaling/v2beta1 and set those when supported also. I see autoscaling/v2beta1 is in 1.24, which doesn't seem that long ago, even if most of us are running newer versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR try: #3033
related issues:
Fix the helper to select the correct HPA on kubernetes >=v1.23.
This new select has tested in my local kubernetes development and the right version has selected!
grafana-6.57.0.tgz
I tested on version 6.57.0 in my local but the issue is the same on the latest version.