[loki-distributed] set unique cluster_label for loki-distributed memberlist #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbsh
changed the title
hobbsh
force-pushed
the
unique-cluster-label-loki
branch
from
3694486 to
d2bda40
Compare
zanhsieh
approved these changes
May 10, 2024
Sheikh-Abubaker
requested changes
Nov 6, 2024
Sheikh-Abubaker
requested changes
Nov 6, 2024
hobbsh
force-pushed
the
unique-cluster-label-loki
branch
from
91abb21 to
636b9a5
Compare
|
@Sheikh-Abubaker done, thank you |
|
@hobbsh could you please sign the DCO, thanks! |
Signed-off-by: Wylie Hobbs <[email protected]>
Signed-off-by: Wylie Hobbs <[email protected]>
Signed-off-by: Wylie Hobbs <[email protected]>
hobbsh
force-pushed
the
unique-cluster-label-loki
branch
from
91b484f to
76aa5c3
Compare
|
@Sheikh-Abubaker Done |
charts/loki-distributed/README.md
Outdated
| @@ -24,6 +24,9 @@ helm repo add grafana https://grafana.github.io/helm-charts | |||
|
|
|||
| Major version upgrades listed here indicate that there is an incompatible breaking change needing manual actions. | |||
|
|
|||
| ### To 0.80.0 | |||
| Introduces a default `cluster_label` for the ring memberlist, which will temporarily disrupt ingestion as it rolls out, unless you temporarily set `cluster_label_verification_disabled`. | |||
There was a problem hiding this comment.
could we have a more descriptive note like: https://github.com/grafana/helm-charts/pull/3058/files#diff-692d159d251d994ada48f63a9a8d8d570ff515aec9a09c1d156544e786d3efa6R44-R45
| @@ -22,6 +22,9 @@ helm repo add grafana https://grafana.github.io/helm-charts | |||
|
|
|||
| Major version upgrades listed here indicate that there is an incompatible breaking change needing manual actions. | |||
|
|
|||
| ### To 0.80.0 | |||
| Introduces a default `cluster_label` for the ring memberlist, which will temporarily disrupt ingestion as it rolls out, unless you temporarily set `cluster_label_verification_disabled`. | |||
There was a problem hiding this comment.
could we have a more descriptive note like: https://github.com/grafana/helm-charts/pull/3058/files#diff-692d159d251d994ada48f63a9a8d8d570ff515aec9a09c1d156544e786d3efa6R44-R45 ?
Signed-off-by: Wylie Hobbs <[email protected]>
|
@Sheikh-Abubaker Done |
Sheikh-Abubaker
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing grafana/tempo#2766 where Loki/Tempo ingesters can join each other's ring because cluster_label seems to be defaulted to something common to both components. This change should mitigate the issue in the future.