Publish chart package to ghcr from the update-helm-repo workflow #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
reviewed
May 10, 2024
| - name: Push charts to GHCR | ||
| run: | | ||
| shopt -s nullglob | ||
| for pkg in .cr-release-packages/*.tgz; do |
There was a problem hiding this comment.
Let's be in sync with the github release and upload ${{ env.CR_PACKAGE_PATH }}/${{ steps.parse-chart.outputs.packagename }}.tgz instead of the for loop. See "Make github release" step.
Later we'll have to deal with provenance as well and the workflow starts by verifying that only one chart needs release. I made it that way to make sure the workflow is simple.
There was a problem hiding this comment.
Sure, I updated this chunk. Please, take another look
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
update-helm-repo-push-oci
branch
from
983b717
to
82848ae
Compare
|
Close in favour of #3366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3068 grafana/mimir#7628
This one is similar to #2443 #2998 but updates the helper workflow, Mimir (and maybe others) use for their helm charts.