Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki-distributed] DOCS fix typo ingester #3129

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

mattclegg
Copy link
Contributor

@mattclegg mattclegg commented May 14, 2024

Split from #2791

@Whyeasy @unguiculus Anything else needed changing here?

@mattclegg mattclegg changed the title DOCS fix typo ingester [loki-distributed] DOCS fix typo ingester May 14, 2024
@mattclegg mattclegg force-pushed the DOCS-fix-typo-ingester branch from a08435d to dbd69a5 Compare May 22, 2024 12:07
@mattclegg
Copy link
Contributor Author

Merged upstream @Whyeasy @unguiculus

Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @mattclegg thanks for the contribution, could you please bump the chart version and address the failed CI lint checks ?

Signed-off-by: Matt Clegg <[email protected]>
@mattclegg mattclegg force-pushed the DOCS-fix-typo-ingester branch from 7704651 to 414a13f Compare July 24, 2024 16:08
@mattclegg
Copy link
Contributor Author

ok @Sheikh-Abubaker

Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @mattclegg Could you please address the CI lint error, if you're facing any issues resolving that error, let me know!!

@zanhsieh zanhsieh requested a review from Sheikh-Abubaker July 30, 2024 00:38
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanhsieh zanhsieh merged commit c0e8b31 into grafana:main Jul 31, 2024
6 checks passed
@mattclegg mattclegg deleted the DOCS-fix-typo-ingester branch August 13, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants