Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promtail] metrics svc labels template bugfix #3165

Closed
wants to merge 9 commits into from

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Jun 10, 2024

Fix for default label issue - bug introduced by #3083

See #3083 (comment)

Closes #3162

@mjnagel mjnagel changed the title fix: svc template promtail bugfix [promtail] fix: svc template promtail bugfix Jun 10, 2024
@mjnagel mjnagel changed the title [promtail] fix: svc template promtail bugfix [promtail] metrics svc labels template bugfix Jun 10, 2024
@mjnagel
Copy link
Contributor Author

mjnagel commented Jun 10, 2024

@zalegrala @zanhsieh this fixes the issue from my previous PR, hopefully a quick one to review/approve 😃

@jimmy-ungerman
Copy link

@zalegrala @zanhsieh this is blocking us as the current chart is in a broken state

@QuentinBisson
Copy link
Contributor

@zalegrala do we need to do anything to have this released?

@zalegrala
Copy link
Contributor

One more review is required @QuentinBisson. Two reviews for every PR in this repo.

@QuentinBisson
Copy link
Contributor

That's good to know :)

@zalegrala
Copy link
Contributor

I'm open to extending the list of maintainers if community folks are interested. Ideally there is a commit history in the repo to show why a person would be a good maintainer. :)

@zalegrala
Copy link
Contributor

Did one of the other PRs handle this? I see no changes on the PR currently.

@mjnagel
Copy link
Contributor Author

mjnagel commented Jun 27, 2024

@zalegrala Looks like #3164 got merged in and covered the same changes as this PR.

@mjnagel mjnagel closed this Jun 27, 2024
@mjnagel mjnagel deleted the promtail-bug-fix-svc branch June 27, 2024 21:29
@Sheikh-Abubaker
Copy link
Collaborator

I'm open to extending the list of maintainers if community folks are interested. Ideally there is a commit history in the repo to show why a person would be a good maintainer. :)

I am interested!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[promtail] 6.16.0 breaks the application if you don't include labels with service
7 participants