-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[promtail] metrics svc labels template bugfix #3165
Conversation
Signed-off-by: Micah Nagel <[email protected]>
0bb519a
to
3a70c4c
Compare
@zalegrala @zanhsieh this fixes the issue from my previous PR, hopefully a quick one to review/approve 😃 |
Signed-off-by: Micah Nagel <[email protected]>
@zalegrala @zanhsieh this is blocking us as the current chart is in a broken state |
@zalegrala do we need to do anything to have this released? |
One more review is required @QuentinBisson. Two reviews for every PR in this repo. |
That's good to know :) |
I'm open to extending the list of maintainers if community folks are interested. Ideally there is a commit history in the repo to show why a person would be a good maintainer. :) |
Did one of the other PRs handle this? I see no changes on the PR currently. |
@zalegrala Looks like #3164 got merged in and covered the same changes as this PR. |
I am interested!! |
Fix for default label issue - bug introduced by #3083
See #3083 (comment)
Closes #3162