Fields: Regex - custom multi-select levels variable #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator-ui__variable-ui' into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui__levels-tweaks
gtk-grafana
changed the title
Merged
|
There is certainly more to follow up on here, but I'll argue as of this this PR we have a minimally shippable feature. |
…ator-ui__variable-ui' into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui__levels-tweaks
…ator-ui__variable-ui' into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui__levels-tweaks
…ator-ui__variable-ui' into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui__levels-tweaks
gtk-grafana
changed the title
matyax
reviewed
Feb 5, 2025
matyax
approved these changes
Feb 5, 2025
| }); | ||
| }; | ||
|
|
||
| updateFilters = (skipPublish: boolean, forcePublish?: boolean) => { |
There was a problem hiding this comment.
Suggested change
| updateFilters = (skipPublish: boolean, forcePublish?: boolean) => { | |
| updateFilters = (skipPublish: boolean, forcePublish = false) => { |
Comment on lines
+131
to
+134
| if (filters.length) { | ||
| return `| ${LEVEL_VARIABLE_VALUE}=~\`${filters.map((f) => f.value).join('|')}\``; | ||
| } | ||
| return ''; |
There was a problem hiding this comment.
Maybe:
Suggested change
| if (filters.length) { | |
| return `| ${LEVEL_VARIABLE_VALUE}=~\`${filters.map((f) => f.value).join('|')}\``; | |
| } | |
| return ''; | |
| if (filters.length > 1) { | |
| return `| ${LEVEL_VARIABLE_VALUE}=~\`${filters.map((f) => f.value).join('|')}\``; | |
| } else if (filters.length === 1) { | |
| return `| ${LEVEL_VARIABLE_VALUE}=\`${filters[0].value}\``; | |
| } | |
| return ''; |
Co-authored-by: Matias Chomicki <[email protected]>
Co-authored-by: Matias Chomicki <[email protected]>
Co-authored-by: Matias Chomicki <[email protected]>
gtk-grafana
merged commit dae9757
into
gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui
3 checks passed
gtk-grafana
deleted the
gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui__levels-tweaks
branch
gtk-grafana
added a commit
that referenced
this pull request
Feb 5, 2025
* Fields: Regex - Supporting regex fields from Explore (#1023) * Fields: Regex - Operator UI updates and double-quotes (#1028) * Fields: Regex - Combining metadata and fields (#1029) * Fields: Regex - custom multi-select levels variable (#1030) --------- Co-authored-by: Matias Chomicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent branch: #1029
This PR adds a custom renderer for the levels field to more prominently surface detected_level filters.