-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply series limit per variant for multi-variant queries #16887
base: main
Are you sure you want to change the base?
Conversation
It's ready again 🚀 |
var hash uint64 | ||
newResult := make([]queryrangebase.SampleStream, 0, len(promResponse.Response.Data.Result)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this, it's going to double the memory needed. I'm going to change this on Tuesday to reuse the slice in the response.
What this PR does / why we need it:
Since multi-variant queries will result in many more series than their traditional counterparts, we need to change how we enforce limits on them. This PR changes the series limiter to apply the limit per variant for multi-variant queries.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR