Skip to content

feat(helm): Make helm labels more specific for antiaffinity #17405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

MaoMaoCake
Copy link

@MaoMaoCake MaoMaoCake commented Apr 23, 2025

What this PR does / why we need it:
Makes the labels for loki pods more specific so as to not cause issues when using with mimir.

Which issue(s) this PR fixes:
Fixes #17404

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Jirapong Pansak <[email protected]>
updates values to use the new labels

Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
Signed-off-by: Jirapong Pansak <[email protected]>
@MaoMaoCake MaoMaoCake requested a review from a team as a code owner April 23, 2025 08:15
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart affinity is not specific enough
2 participants