fix: Prometheus scrape config with configurable port #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
I noticed that the
gdev-prometheusdatasource didn't have the expected metrics unless I had a Grafana instance running on port3000. This PR:grafanacontainer when we haveGRAFANA_PORT=3001set in.envconfig/README.mdto explain how this works and how to extend it to other ports3.2.1(the latest version, currently)How to test
GRAFANA_PORT=3001in.envdocker compose downnpm run servernpm run devgdev-prometheuswith Metrics Drilldown, you should see more than 5 metrics in the Metric Select scene