Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm : fix alermanager-statefulset serviceAccountName field #10016

Conversation

QuantumEnigmaa
Copy link
Contributor

What this PR does

This PR fixes the serviceAccountName field in the alertmanager-statefulset template in the helm chart.

Currently, using the alertmanager.serviceAccount.name field in the helm chart values doesn't work as the current alertmanager-statefulset template is using the default mimir service-account name.

Which issue(s) this PR fixes or relates to

No issues created for this.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner November 25, 2024 10:49
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot, thanks for fixing it

@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) November 25, 2024 11:52
@dimitarvdimitrov dimitarvdimitrov merged commit 289a1ab into grafana:main Nov 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants