Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor kadm from upstream #8913

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Vendor kadm from upstream #8913

merged 1 commit into from
Aug 6, 2024

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Aug 6, 2024

What this PR does

The PR twmb/franz-go#775 has been merged and included in kadm v1.13.0. We can remove the import override and vendor kadm from upstream again.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci requested review from stevesg, grafanabot and a team as code owners August 6, 2024 12:39
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥

@pracucci pracucci merged commit 7226726 into main Aug 6, 2024
29 checks passed
@pracucci pracucci deleted the vendor-kadm-from-upstream branch August 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants