Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump com.google.protobuf:protobuf-java to 4.29.2 #177

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Jan 8, 2025

Addresses a few security vulnerabilities caused by older versions of com.google.protobuf:protobuf-java

@aleks-p aleks-p requested review from a team as code owners January 8, 2025 13:52
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsut curious is this needed to be present at runtime for some features in knew protobuf versions or is it just for convenience?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we don't need it. It doesn't cause any harm, but we don't need noise in the jar anyway. I've moved it out of the src folder entirely.

@aleks-p aleks-p merged commit 05f5dde into main Jan 9, 2025
40 checks passed
@aleks-p aleks-p deleted the chore/bump-protobuf branch January 9, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants