Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update self-hosted runner labels to be more specific #166

Closed
wants to merge 1 commit into from

Conversation

guicaulada
Copy link

@guicaulada guicaulada commented May 23, 2024

This pull request updates the runner labels on workflows that are running self-hosted runners to use more specific and explicit labels, the current labels can be interpreted wrongly by the system resulting in dev instances picking up jobs for prod instances.

Part of https://github.com/grafana/deployment_tools/issues/142178
Part of https://github.com/grafana/deployment_tools/issues/142917

Related grafana/pyroscope-dotnet#64

@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guicaulada
Copy link
Author

Apparently jobs are not being picked up, I'm looking into it.

@guicaulada
Copy link
Author

guicaulada commented May 23, 2024

Why does this repository doesn't have access to organization wide self-hosted runners?

Grafana org runners should be showing up here: https://github.com/grafana/pyroscope-rs/actions/runners?tab=self-hosted

@guicaulada
Copy link
Author

Looking into that now.

@guicaulada
Copy link
Author

Apparently we will postpone this for public repositories.

@guicaulada guicaulada closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants