Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usage of a deprecated Node.js version in CI #3668

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: usage of a deprecated Node.js version in CI #3668

merged 1 commit into from
Nov 11, 2024

Conversation

hamirmahal
Copy link
Contributor

Fixes #3667

@hamirmahal hamirmahal requested a review from a team as a code owner November 6, 2024 23:52
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

hamirmahal
hamirmahal commented Nov 6, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is the latest major version of actions/checkout and actions/setup-node at the time of this pull request's creation.

@marcsanmi marcsanmi force-pushed the fix/usage-of-a-deprecated-nodejs-version-in-frontend-yml branch from e01c058 to 213a29b Compare November 11, 2024 15:11
marcsanmi
marcsanmi approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @hamirmahal

@marcsanmi marcsanmi merged commit ebc732f into grafana:main Nov 11, 2024
18 checks passed
@hamirmahal hamirmahal deleted the fix/usage-of-a-deprecated-nodejs-version-in-frontend-yml branch November 11, 2024 18:53
@hamirmahal
Copy link
Contributor Author

You're welcome, @marcsanmi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcsanmi marcsanmi marcsanmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frontend.yml uses checkout@v3 and setup-node@v3 which use a deprecated Node.js version
3 participants
@hamirmahal @CLAassistant @marcsanmi