Fix the getLegacyPanelId method in VizPanel
#1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfmatei
added
patch
bfmatei
requested review from
torkelo,
axelavargas,
oscarkilhed,
dprokop,
ivanortegaalba,
mdvictor and
Sergej-Vlasov
3 tasks
Sergej-Vlasov
approved these changes
Feb 13, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix needed after grafana/grafana#99300 (rows refactor)
The
getLegacyPanelIdmethod was returning the id for the first part of the key in a clone chain.This requires a way better fix as it was already clunky from the beginning (cloned panels are having keys like
panel-X-clone-ABCwhereABCis now the clone index while previously it was the variable value).For the time being this is a hotfix to solve any active/potential incidents.
📦 Published PR as canary version:
6.0.2--canary.1053.13305029685.0✨ Test out this PR locally via: