Fix issue were operators do not appear properly in adhoc vars #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in dashboards where adhocs do not show the regex operators even though they should appear since the variable settings UI page shows
Allow custom valuestrue, by default. This only happens when the flag is set by default and not explicitly in the model.To maintain backwards comp, I added the
allowCustomValuesflag and set it to true by default (as custom values worked by default before this flag), but not in the model, so that it wouldn't change the dashboard model.If I were to have added the flag in the constructor with a default value when undefined this issue wouldn't have happened, but then all dashboards would have their models changed and a new line for allowing custom values would be serialized in adhoc vars in already saved dashboards.