Perform history step on MultiValueVariable #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment history step on MultiValueVariable.ts
adrapereira
requested review from
torkelo,
axelavargas,
ifrost,
dprokop and
joey-grafana
|
@adrapereira can you take a look at #882 ? It adds browser history to variables (that extend MultiValueVariable), and only creates history steps when user initiates the change (which I think is important) |
|
Closing in favour of #882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to "copy" the approach used in
SceneObjectUrlSyncConfigto create history steps when the value is updated. I added theperformBrowserHistoryActionfunction to theSceneObjectUrlSyncHandlerinterface and implemented it inMultiValueUrlSyncHandler. If this approach sounds good I can also do it for other classes implementingSceneObjectUrlSyncHandlerlike in AdHocFiltersVariable, GroupByVariable, etc.This is needed because in traces-drilldown we make extensive use of
CustomVariableand are trying to create history steps whenever a variable updates.There should be no breaking changes.