AdhocVariable: baseFilters with origin appear readonly in the UI
#1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mdvictor
added
patch
dprokop
reviewed
Feb 25, 2025
| @@ -25,10 +25,18 @@ export interface AdHocFilterWithLabels<M extends Record<string, any> = {}> exten | |||
| // hide the filter from AdHocFiltersVariableRenderer and the URL | |||
| hidden?: boolean; | |||
| meta?: M; | |||
| // filter source, it can be either scopes, dashboards or undefined, | |||
| // which means it won't appear in the UI | |||
| source?: FilterSource; | |||
There was a problem hiding this comment.
uber nit: we use origin term in data frames to identify origin field/data frame. Think we can align the terminiology.
dprokop
approved these changes
Feb 26, 2025
mdvictor
changed the title
baseFilters with a source as readonly in the UIbaseFilters with origin as readonly in the UI
mdvictor
changed the title
baseFilters with origin as readonly in the UIbaseFilters with origin appear readonly in the UI
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseFiltersare usually hidden away within the adhoc variable but affect the returned keys and values.With this PR we allow showing
baseFiltersin the UI if they are specifically sourced (e.g.: from a scope). They are currently read-only and work as a visual aid to translating selected scopes into actual filters.Related to grafana/grafana#101217
📦 Published PR as canary version:
6.1.4--canary.1060.13562828942.0✨ Test out this PR locally via: