Build: using @grafana/toolkit

[ryantxu]

trying with @grafana/toolkit

Note you need to yarn link @grafana/toolkit manually until we release it!

[CLAassistant]

All committers have signed the CLA.

[amotl]

Dear Ryan,

we recognize you are a member of Grafana Labs and so you might be in touch with @daniellee occasionally. We just wanted to take the chance here to humbly mention that we've put significant efforts into a revamped version of the Grafana Worldmap Panel at [1]. We also reported about its improvements and features at [2] in detail and summerized the whole shebang at [3].

So, we are humbly asking to discuss this with @daniellee, @dprokop, @torkelo or other colleagues whether you would be interested mainlining this? ¹ I am asking this now because significant changes like the ones you just contributed will probably make it more difficult to bring things together again in the future.

Thanks for listening and thanks for building Grafana.

With kind regards,
Andreas.

[1] https://github.com/hiveeyes/grafana-worldmap-panel
[2] https://community.hiveeyes.org/t/grafana-worldmap-panel-ng/1824
[3] https://community.grafana.com/t/giving-the-grafana-worldmap-panel-some-love/17210

---

¹ Sorry for not having turned this into an official pull request already. We still feel this might undergo some more tests by downstream and upstream users (you) before considering that. As we will be happy to fix eventual issues with it, we will be happy to push these things further.

[daniellee]

@amotl sorry for not getting back to you before. We are interested in mainlining your changes - just haven't made time for it yet.

[ryantxu]

Hi @amotl -- your fork looks really interesting, thanks for pointing me to it. I will take a look this week and see what path makes sense.

FYI, this PR is part of a larger effort to simplify plugin development and testing. See:
grafana/grafana#17819 I have a similar PR in ~20 plugins. My goal is to get a single build script/tool that will build and test everything consistently.

[amotl]

Dear @daniellee and @ryantxu ,

We are interested in mainlining your changes - just haven't made time for it yet.

Thank you so much for taking the time to have a look at the work we did over at [1] and for signalling your interest. Please take your time on further steps as you like, we just wanted to make sure you know about it.

This PR is part of a larger effort to simplify plugin development and testing. My goal is to get a single build script/tool that will build and test everything consistently.

Thanks for letting us know. Sounds like a good plan.

I will take a look [at your fork] this week and see what path makes sense.

Thanks. We added some of our thoughts at [2]. Please let us know if that resonates with you or if you need our support otherwise as soon as you can catch some time for applying further steps. Thanks already for your pull requests from [2] as well as [3] (WIP). We will try to build a semi-official grafana-worldmap-panel-ng-0.4.0 dist package from that after leaving wip-status behind and publish it on its GitHub release page as outlined within [2].

Thanks again, good luck for your work and with kind regards,
Andreas.

[1] https://github.com/hiveeyes/grafana-worldmap-panel
[2] grafana-toolbox#4 (comment)
[3] grafana-toolbox#5

[ryantxu]

Thanks again @amotl

I will work on using @grafana/toolkit and a path towards merging in your fork.