integration: properly parse output metrics and assert more things about them #44
+202
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
integration-prometheus
branch
2 times, most recently
from
5bb2694 to
70d4eec
Compare
nadiamoe
changed the title
nadiamoe
force-pushed
the
integration-prometheus
branch
from
70d4eec to
80516fc
Compare
nadiamoe
changed the title
nadiamoe
force-pushed
the
integration-prometheus
branch
from
f36271d to
7b04031
Compare
nadiamoe
commented
Jan 15, 2025
Comment on lines
-22
to
-34
| t.Run("metrics", func(t *testing.T) { | ||
| for _, tc := range []struct { | ||
| name string | ||
| script []byte | ||
| }{ | ||
| { | ||
| name: "singleRequest", | ||
| script: scriptSingleRequest, | ||
| }, | ||
| } { | ||
| tc := tc | ||
|
|
||
| t.Run(tc.name, func(t *testing.T) { |
There was a problem hiding this comment.
This used to create two subtests, one for metrics and then one for each script we run. As it turns out, we only test for metrics and we only run that script, so I removed these two subtests entirely and decreased indentation a bunch. Git does not do a good job displaying this indentation change.
Feel free to switch to the single commit view for a less noisy diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the existing integration test making it more exhaustive.
Previously, the extension output was parsed as text and it was checked as such, which only allowed for few assertions to be made without very complicated code.
This PR imports the Prometheus parser and data models, and parses the output with them. This unblocks more exhaustive assertions, which I also add on this PR.
The main motivation for this PR is to get good coverage to assert that the big refactor in #34 is still conformant with the previous behavior.