Fix topic subscriptions QOS

grafnu · Apr 20, 2024 · 954b0fc · 954b0fc
1 parent 1e29842
commit 954b0fc
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/validator/src/main/java/com/google/bos/iot/core/proxy/MqttPublisher.java b/validator/src/main/java/com/google/bos/iot/core/proxy/MqttPublisher.java
@@ -408,7 +408,7 @@ private void connectAndSetupMqtt() {
       mqttClient.connect(mqttConnectOptions);
       attachedClients.clear();
       attachedClients.add(deviceId);
-      subscribeToUpdates(deviceId);
+      subscribeToConfig(deviceId);
       subscribeToErrors(deviceId);
       subscribeToCommands(deviceId);
       LOG.info(deviceId + " done with setup connection");
@@ -471,26 +471,26 @@ private String getMessageTopic(String deviceId, String topic) {
     return topicBase + format(MESSAGE_TOPIC_FMT, topic);
   }
 
-  private void subscribeToUpdates(String deviceId) {
-    clientSubscribe(CONFIG_TOPIC, QOS_AT_MOST_ONCE);
+  private void subscribeToConfig(String deviceId) {
+    clientSubscribe(CONFIG_TOPIC, QOS_AT_LEAST_ONCE);
   }
 
   private void clientSubscribe(String topicSuffix, int qos) {
     String topic = topicBase + topicSuffix;
     try {
-      LOG.info("Subscribed to mqtt topic " + topic);
+      LOG.info(format("Subscribing with qos %d to topic %s", qos, topic));
       mqttClient.subscribe(topic, qos);
     } catch (MqttException e) {
       throw new RuntimeException("While subscribing to MQTT topic " + topic, e);
     }
   }
 
   private void subscribeToErrors(String deviceId) {
-    clientSubscribe(ERROR_TOPIC, QOS_AT_MOST_ONCE);
+    clientSubscribe(ERROR_TOPIC, QOS_AT_LEAST_ONCE);
   }
 
   private void subscribeToCommands(String deviceId) {
-    clientSubscribe(COMMAND_TOPIC, QOS_AT_LEAST_ONCE);
+    clientSubscribe(COMMAND_TOPIC, QOS_AT_MOST_ONCE);
   }
 
   String getDeviceId() {