Skip to content

Commit

Permalink
Merge pull request #100 from grails/merge-4.1.x-into-5.0.x
Browse files Browse the repository at this point in the history
Merge 4.1.x into 5.0.x
  • Loading branch information
matrei authored Dec 12, 2024
2 parents d268584 + a8694fc commit e60f02a
Show file tree
Hide file tree
Showing 5 changed files with 82 additions and 72 deletions.
16 changes: 11 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ buildscript {
}
}

plugins {
id 'com.github.ben-manes.versions' version '0.51.0'
}

version = projectVersion
group = 'org.grails.plugins'

Expand All @@ -23,15 +27,15 @@ repositories {
maven { url = 'https://repo.grails.org/grails/core' }
}

configurations {
documentation.extendsFrom compileClasspath
}
configurations.register('documentation')

ext.set('selenium.version', seleniumVersion) // Override selenium version from spring-boot-dependencies

dependencies {

implementation(platform("org.grails:grails-bom:$grailsVersion"))

compileOnly 'org.grails:grails-core' // Provided as this is a Grails plugin
compileOnly 'org.grails:grails-core' // Provided, as this is a Grails plugin

testFixturesCompileOnly 'jakarta.servlet:jakarta.servlet-api'
testFixturesCompileOnly 'org.slf4j:slf4j-simple' // Remove compilation warning about missing slf4j impl
Expand All @@ -45,6 +49,7 @@ dependencies {
documentation 'org.apache.groovy:groovy'
documentation 'org.apache.groovy:groovy-ant'
documentation 'org.apache.groovy:groovy-templates'
documentation 'org.apache.groovy:groovy-xml'
documentation 'com.github.javaparser:javaparser-core'
}

Expand All @@ -68,6 +73,7 @@ tasks.withType(Groovydoc).configureEach {
destinationDir = layout.buildDirectory.dir('docs/api').get().asFile
docTitle = "Grails Geb Plugin ${version}"
classpath = configurations.documentation
source = files(source, sourceSets.testFixtures.allSource)
}

tasks.withType(Test).configureEach {
Expand All @@ -84,4 +90,4 @@ tasks.withType(Test).configureEach {
tasks.named('bootJar') { enabled = false }
tasks.named('bootRun') { enabled = false }
tasks.named('bootTestRun') { enabled = false }
tasks.named('findMainClass') { enabled = false }
tasks.named('findMainClass') { enabled = false }
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
projectVersion=5.0.0-SNAPSHOT
grailsVersion=7.0.0-SNAPSHOT
grailsGradlePluginVersion=7.0.0-SNAPSHOT
seleniumVersion=4.25.0
seleniumVersion=4.27.0
testcontainersVersion=1.20.4

# This prevents the Grails Gradle Plugin from unnecessarily excluding slf4j-simple in the generated POMs
Expand Down
92 changes: 46 additions & 46 deletions spock-container-test-app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,60 +1,60 @@
plugins {
id "groovy"
id "org.grails.grails-web"
id "org.grails.grails-gsp"
id "war"
id "idea"
id "com.bertramlabs.asset-pipeline" version "5.0.1"
id "eclipse"
buildscript {
repositories {
maven { url = 'https://repo.grails.org/grails/core' }
mavenCentral()
}
dependencies {
classpath "org.grails:grails-gradle-plugin:$grailsGradlePluginVersion"
}
}

group = "org.demo.spock"
apply plugin: 'groovy'
apply plugin: 'org.grails.grails-web'
apply plugin: 'org.grails.grails-gsp'

group = 'org.demo.spock'

repositories {
maven { url = 'https://repo.grails.org/grails/core' }
mavenCentral()
maven { url "https://repo.grails.org/grails/core/" }
maven { url "https://repository.apache.org/content/repositories/snapshots"}
}

dependencies {
profile("org.grails.profiles:web")
implementation("org.grails:grails-core")
implementation("org.grails:grails-logging")
implementation("org.grails:grails-plugin-databinding")
implementation("org.grails:grails-plugin-i18n")
implementation("org.grails:grails-plugin-interceptors")
implementation("org.grails:grails-plugin-rest")
implementation("org.grails:grails-plugin-services")
implementation("org.grails:grails-plugin-url-mappings")
implementation("org.grails:grails-web-boot")
implementation("org.grails.plugins:gsp")
implementation("org.grails.plugins:hibernate5")
implementation("org.grails.plugins:scaffolding")
implementation("org.sitemesh:grails-plugin-sitemesh3:7.0.0-SNAPSHOT")
implementation("org.springframework.boot:spring-boot-autoconfigure")
implementation("org.springframework.boot:spring-boot-starter")
implementation("org.springframework.boot:spring-boot-starter-actuator")
implementation("org.springframework.boot:spring-boot-starter-logging")
implementation("org.springframework.boot:spring-boot-starter-tomcat")
implementation("org.springframework.boot:spring-boot-starter-validation")
console("org.grails:grails-console")
runtimeOnly("com.bertramlabs.plugins:asset-pipeline-grails")
runtimeOnly("com.h2database:h2")
runtimeOnly("org.apache.tomcat:tomcat-jdbc")
runtimeOnly("org.fusesource.jansi:jansi")

implementation 'org.grails:grails-core'
implementation 'org.grails:grails-logging'
implementation 'org.grails:grails-plugin-databinding'
implementation 'org.grails:grails-plugin-i18n'
implementation 'org.grails:grails-plugin-interceptors'
implementation 'org.grails:grails-plugin-rest'
implementation 'org.grails:grails-plugin-services'
implementation 'org.grails:grails-plugin-url-mappings'
implementation 'org.grails:grails-web-boot'
implementation 'org.grails.plugins:gsp'
implementation 'org.grails.plugins:hibernate5'
implementation 'org.grails.plugins:scaffolding'
implementation 'org.springframework.boot:spring-boot-autoconfigure'
implementation 'org.springframework.boot:spring-boot-starter'
implementation 'org.springframework.boot:spring-boot-starter-actuator'
implementation 'org.springframework.boot:spring-boot-starter-logging'
implementation 'org.springframework.boot:spring-boot-starter-tomcat'
implementation 'org.springframework.boot:spring-boot-starter-validation'

runtimeOnly 'com.bertramlabs.plugins:asset-pipeline-grails'
runtimeOnly 'com.h2database:h2'
runtimeOnly 'org.apache.tomcat:tomcat-jdbc'
runtimeOnly 'org.fusesource.jansi:jansi'

testImplementation 'org.grails:grails-gorm-testing-support'
testImplementation 'org.grails:grails-web-testing-support'
testImplementation 'org.spockframework:spock-core'

integrationTestImplementation testFixtures(project(':geb'))
testImplementation("org.grails:grails-gorm-testing-support")
testImplementation("org.grails:grails-web-testing-support")
testImplementation("org.spockframework:spock-core")
}

compileJava.options.release = 17

tasks.withType(Test) {
tasks.withType(Test).configureEach {
useJUnitPlatform()
systemProperty 'grails.geb.recording.mode', 'RECORD_ALL'
}
assets {
minifyJs = true
minifyCss = true
}
systemProperty('grails.geb.recording.mode', 'RECORD_ALL')
}
10 changes: 0 additions & 10 deletions spock-container-test-app/buildSrc/build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +0,0 @@
repositories {
mavenCentral()
maven { url "https://repo.grails.org/grails/core/" }
maven { url "https://repository.apache.org/content/repositories/snapshots"}
}
dependencies {
implementation platform("org.grails:grails-bom:7.0.0-SNAPSHOT")
implementation("org.grails:grails-gradle-plugin:7.0.0-SNAPSHOT")
implementation("org.grails.plugins:hibernate5:9.0.0-SNAPSHOT")
}
34 changes: 24 additions & 10 deletions spock-container-test-app/settings.gradle
Original file line number Diff line number Diff line change
@@ -1,17 +1,31 @@
plugins {
id 'com.gradle.develocity' version '3.18.2'
id 'com.gradle.common-custom-user-data-gradle-plugin' version '2.0.2'
}

def isCI = System.getenv('CI') != null
def isLocal = !isCI
def isAuthenticated = System.getenv('DEVELOCITY_ACCESS_KEY') != null

pluginManagement {
repositories {
mavenLocal()
maven { url "https://repo.grails.org/grails/core/" }
gradlePluginPortal()
develocity {
server = 'https://ge.grails.org'
buildScan {
tag('grails')
tag('grails/geb')
publishing.onlyIf { isAuthenticated }
uploadInBackground = isLocal
}
plugins {
id "org.grails.grails-web" version "7.0.0-SNAPSHOT"
id "org.grails.grails-gsp" version "7.0.0-SNAPSHOT"
}

buildCache {
local { enabled = isLocal }
remote(develocity.buildCache) {
push = isCI && isAuthenticated
enabled = true
}
}

rootProject.name="spock-container-test-app"
include 'geb'
rootProject.name = 'spock-container-test-app'

include 'geb'
project(':geb').projectDir = file('..')

0 comments on commit e60f02a

Please sign in to comment.