Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.x - backport setup() methods being called #107

Merged
merged 1 commit into from
Dec 18, 2024
Merged

4.1.x - backport setup() methods being called #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/testFixtures/groovy/grails/plugin/geb/GebRecordingTestListener.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ import groovy.transform.CompileStatic
import org.spockframework.runtime.AbstractRunListener
import org.spockframework.runtime.model.ErrorInfo
import org.spockframework.runtime.model.IterationInfo
import org.spockframework.runtime.model.SpecInfo

import java.time.LocalDateTime

/**
* A test listener that reports the test result to {@link org.testcontainers.containers.BrowserWebDriverContainer} so
Expand Down
6 changes: 4 additions & 2 deletions src/testFixtures/groovy/grails/plugin/geb/GrailsContainerGebExtension.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,11 @@ class GrailsContainerGebExtension implements IGlobalExtension {
invocation.proceed()
}

spec.addSetupInterceptor {
spec.addSetupInterceptor { invocation ->
// Grails will be initialized by this point, so setup the browser url correctly
holder.setupBrowserUrl(it)
holder.setupBrowserUrl(invocation)

invocation.proceed()
}

spec.addInterceptor { invocation ->
Expand Down
Loading