Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includeBuild syntax so it works with grailsPublish #108

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jdaugherty
Copy link
Contributor

@matrei & I noticed that the tests in the test project fail to run when the project version is considered a release version. The error it gives is:

 A problem occurred evaluating project ':geb'.
 > Failed to apply plugin class 'io.github.gradlenexus.publishplugin.NexusPublishPlugin'.
    > Cannot run Project.afterEvaluate(Action) when the project is already evaluated.

The existing include syntax in the build causes this. After adding end to end testing for the grails-gradle-plugin (https://github.com/jdaugherty/grails-gradle-plugin/actions/runs/12404566767), I was able to isolate this and discovered there's also a includeBuild syntax.

Switching to the includeBuild syntax fixes the subproject so it works regardless of the geb project's version.

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

spock-container-test-app/settings.gradle Outdated Show resolved Hide resolved
@jdaugherty jdaugherty merged commit 077a6b8 into grails:5.0.x Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants