Cross-Platform Geb FileInput module support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue on Windows when using the file from `container.copyFileToContainer()` with the Geb FileInput module.
`macos-latest` does not seem to have container support.
`windows-latest` does not seem to provide a container environment.
jdaugherty
reviewed
Jan 9, 2025
src/testFixtures/groovy/grails/plugin/geb/support/ContainerGebFileInputSource.groovy
Outdated
Show resolved
Hide resolved
- Use `replace(char, char)` instead of `replaceAll(String, String)` to avoid the overhead of regex pattern compilation. - Replace hardcoded string literals with `File.separatorChar`, ensuring the `replace` operation is a no-op on non-Windows hosts where no substitution is needed.
jdaugherty
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue on Windows when using the file from
container.copyFileToContainer()with the Geb FileInput module.As this is a new feature I created it against a new 4.2.x branch for Grails 6.