Make download*() methods work in ContainerGebSpec
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There must be a more elegant way to solve this, but this seems to work. Resolves gh-72
…inerGebSpec` Allows specifying `hostName` directly in `ContainerGebSpec` specs, e.g., `String hostName = 'my.test.app'`, to streamline test setup and improve readability.
Replaced direct field access with state getters to improve readability and encapsulation. This change makes it clearer how state is accessed and managed within the class.
…ation - Converted `ContainerGebSpec` to an abstract class to ensure it is only used as a base class for other specs. - This change enforces intended usage patterns and prevents accidental instantiation of `ContainerGebSpec`.
…dSupport` Renamed `ContainerAwareDownloader` to `ContainerAwareDownloadSupport` to better reflect that it's a `DownloadSupport` implementation.
jdaugherty
approved these changes
Nov 15, 2024
|
@sbglasius Do you want to take a look before I merge this? |
sbglasius
approved these changes
Nov 15, 2024
src/testFixtures/groovy/grails/plugin/geb/ContainerGebSpec.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/ContainerAwareDownloadSupport.groovy
Show resolved
Hide resolved
With this commit `ContainerAwareDownloadSupport` uses an inner class for delegating to `DefaultDownloadSupport` instead of duplicating all its functionality. As all `download*()` methods eventually invokes `download(Map options)` it is enough to override this method, and changing the `base` option in the map to use the proper url.
matrei
changed the title
download*() methods workdownload*() methods work in ContainerGebSpec
|
@matrei Well done with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves gh-72