Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and cleanup build #97

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Update and cleanup build #97

merged 7 commits into from
Dec 12, 2024

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Dec 12, 2024

  • Remove buildSrc
  • Remove pluginManagement
  • Update dependencies
  • Use Groovy provided by Gradle for documentation generation
  • Set grails-core dependency as provided
  • Remove redundant assets config
  • Remove redundant Gradle plugins
  • Use Groovy style in build files
  • Set grailsCentral as the first dependency repository
  • Move sourceCompatibility inside java config block (target is inherited)
  • Add textFixtures sources to groovydoc generation
  • Add slf4j-nop to clear compile warning
  • Move all versions to gradle.properties
  • Change to proper exclusions for geb-spock dependency
  • Override selenium version set by spring-boot-dependencies
  • Add develocity gradle plugins for build scans and remote cache

- Remove buildSrc
- Remove pluginManagement
- Update dependencies
- Use Groovy provided by Gradle for documentation generation
- Set `grails-core` dependency as provided
- Remove redundant `assets` config
- Remove redundant Gradle plugins
- Use Groovy style in build files
- Set `grailsCentral` as the first dependency repository
- Move `sourceCompatibility` inside java config block (target is inherited)
- Add `textFixtures` sources to `groovydoc` generation
- Add `slf4j-nop` to clear compile warning
- Move all versions to `gradle.properties`
- Change to proper exclusions for `geb-spock` dependency
- Override `selenium` version set by `spring-boot-dependencies`
Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@matrei matrei requested a review from jdaugherty December 12, 2024 09:35
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
gradle.properties Show resolved Hide resolved
spock-container-test-app/build.gradle Show resolved Hide resolved
spock-container-test-app/build.gradle Show resolved Hide resolved
spock-container-test-app/build.gradle Show resolved Hide resolved
spock-container-test-app/build.gradle Show resolved Hide resolved
spock-container-test-app/gradle.properties Show resolved Hide resolved
spock-container-test-app/settings.gradle Show resolved Hide resolved
Refactored the registration logic for documentation configuration to enhance readability and make the purpose of the code clearer. This change improves maintainability and reduces potential confusion.
The grails-gradle-plugin now handles this functionality, so the explicit disabling is no longer necessary.
@matrei matrei merged commit 4de9b64 into 4.1.x Dec 12, 2024
5 checks passed
@matrei matrei deleted the matrei/update-4.1.x-build branch December 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants