Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Add == operator to Queue module #1931

Merged
merged 3 commits into from
Jan 2, 2024
Merged

feat(stdlib): Add == operator to Queue module #1931

merged 3 commits into from
Jan 2, 2024

Conversation

spotandjake
Copy link
Member

This pr adds Queue.equal which provides a more useful equality check that cares about the queue contents rather than internal structure.

@spotandjake spotandjake self-assigned this Dec 4, 2023
@ospencer
Copy link
Member

I agree with @alex-snezhko that we should name it (==).

@spotandjake spotandjake changed the title feat(stdlib): add Queue.equal feat(stdlib): add Queue.(==) Dec 12, 2023
@spotandjake
Copy link
Member Author

I agree with @alex-snezhko that we should name it (==).

Made that change

@phated phated changed the title feat(stdlib): add Queue.(==) feat(stdlib): Add == operator to Queue module Dec 29, 2023
phated
phated reviewed Dec 29, 2023
View reviewed changes
@spotandjake
Copy link
Member Author

Applied that suggestion

@phated
Copy link
Member

phated commented Dec 31, 2023

@spotandjake please resolve the conflicts 🙏

@phated phated enabled auto-merge December 31, 2023 22:50
@phated phated added this pull request to the merge queue Dec 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 31, 2023
@phated
Copy link
Member

phated commented Jan 1, 2024

@spotandjake it looks like this conflicts again. Can you update?

@spotandjake spotandjake force-pushed the spotandjake-queue-eq branch from 4bb62ab to 8b964ea Compare January 1, 2024 22:29
@spotandjake
Copy link
Member Author

Updated

@phated phated enabled auto-merge January 1, 2024 22:32
@phated phated added this pull request to the merge queue Jan 1, 2024
Merged via the queue into grain-lang:main with commit 3c0ea18 Jan 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@ospencer ospencer Awaiting requested review from ospencer ospencer is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@spotandjake spotandjake

Labels
stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spotandjake @ospencer @phated