Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequencer.py #208

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Update sequencer.py #208

merged 4 commits into from
Feb 6, 2024

Conversation

jckenny59
Copy link
Contributor

Updating sequencer.py SimpleSequenceGenerator() def result() to work with compas.datastructers.assembly. If instanceis(self.assembly, TimberAssembly) steps are created from beam elements. If compas.datastructuers.assembly steps are created from assembly parts.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Updating sequencer.py SimpleSequenceGenerator() to work with standard assemblies, and if instanceis TimberAssembly steps are created from beam elements. But if instance is Assembly steps are created from assembly parts
@jckenny59 jckenny59 requested a review from chenkasirer February 6, 2024 09:07
@jckenny59 jckenny59 marked this pull request as draft February 6, 2024 09:11
@jckenny59 jckenny59 marked this pull request as ready for review February 6, 2024 09:26
Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/compas_timber/planning/sequencer.py Outdated Show resolved Hide resolved
jckenny59 and others added 2 commits February 6, 2024 14:33
update annotation to to just compas.datastructures.Assembly
@jckenny59 jckenny59 merged commit 2c3748f into main Feb 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants