fix max_distance bugs
#390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkasirer
reviewed
Feb 11, 2025
src/compas_timber/utils/__init__.py
Outdated
| if not pta: # segments are parallel | ||
| dists = [] | ||
| for pair in [(segment_a[0], segment_b[0]), (segment_a[1], segment_b[0]), (segment_b[0], segment_a[1]), (segment_b[1], segment_a[1])]: | ||
| """gets shortest distance between all 4 possible pairs of endpoints. only for L/I_Topo. T_Topology cannot have paralell segments""" |
There was a problem hiding this comment.
please use # for in-code comments
There was a problem hiding this comment.
if possible, try to use something from https://docs.python.org/3/library/itertools.html here instead. would make for a more readable code.
| @@ -91,23 +91,24 @@ def joints_from_beams_and_rules(elements, rules, max_distance=TOL.absolute): | |||
| element_pairs = solver.find_intersecting_pairs(elements, rtree=True, max_distance=max_rule_distance) | |||
| joint_defs = [] | |||
| unmatched_pairs = [] | |||
| compliant_direct_rules = [] | |||
| for rule in direct_rules: | |||
| if rule.comply(rule.elements, model_max_distance=max_distance): # see if pair complies with max distance | |||
There was a problem hiding this comment.
if rule already contains the elements, why do they need to be passed from the outside?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes after adding
max_distanceto joint rules.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.