bug fix: 5.2.0-1 allows home access, also changes workflow to compile pull requests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OzarkShepherd
commented
Mar 12, 2024
OzarkShepherd
commented
- allows home access to restore access to databases from the 5.1 flatpak and system installations of Gramps
- adds comments in case flathub allows ~/.gramps, xdg-data, xdg-config, and xdg-cache in the future
- changes workflow to run on pull requests so that a gramps.flatpak can be made for PR's
lines 13-17 for xdg-data, xdg-config, xdg-cache, and .gramps:create
Flathub does not allow xdg-data, xdg-config, or xdg-cache so I changed them to the actual directories in lines 15-18
xdg-data, xdg-config, and xdg-cache are blocked from flathub. naming those directories causes a compiling error in flatpak builder. only ~/.gramps access will be allowed
lines 15-18 ~/.locale/share:create ~/.config:create ~/.cache:create
gives create option for data directories
this is a bug fix; users are losing data due to our attempt to use specific xdg directories, but flathub rules regarding xdg data and config directories are blocking resolution
if necessary xdg access is allowed in future, then adding the create option now for xdg-documents, xdg-data, xdg-config, and xdg-cache so new databases can be created from Gramps will keep me from forgetting later also fixed a typo
|
since it is a bug fix for users who lost data, I pushed this version with home access this morning and flathub is sending it out to users now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.