-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenHistoricalMap layer to maps #454
Changes from 10 commits
eb0e7ab
95da99c
e5fa8c6
eb8bcb7
74a8b06
3d2deeb
6e78609
109615a
48de6cd
5958d8c
7628d92
734ea4c
2a31281
7ed30be
cbe4cbd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,6 +114,7 @@ class GrampsjsFormEditLatLong extends GrampsjsObjectForm { | |
<grampsjs-map | ||
latitude="${this.data.lat ? parseFloat(this.data.lat) : 0}" | ||
longitude="${this.data.long ? parseFloat(this.data.long) : 0}" | ||
layerSwitcher | ||
mapid="edit-latlong-map" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some of these maps come with search boxes powered by OpenStreetMap’s Nominatim instance. OHM has its own Nominatim instance too. It’s a bit rough around the edges, but in the future, maybe we could switch to it whenever the map is showing the OHM layer, for consistency. |
||
id="map" | ||
@click="${this._handleMapClick}" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This compatibility shim works, but it preserves the Leaflet user experience, which is much less fluid than MapLibre GL JS. Migrating from Leaflet to MapLibre GL JS would enable smooth zooming, rotation, and better rendering performance. Something to consider for the future.