Optionally disable c bindings #278
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix compute roots of unity issues for test to pass _fft_field helper function fix traits implementations for compute_roots_of_unity compute_cells_and_kzg_proof implement reverse bit order Configured EIP-7594 vector tests blst implement compute_cells_and_kzg_proofs, start implementing recover_cells_and_kzg_proofs recovery Cell recovery Proof recovery verify_cell_kzg_proof_batch bug fix bug fixes Fix bindings Fix clippy issues EIP-7594 trait implementation Optimized verify_cell_kzg_proof_batch by adding #[cfg(feature = "parallel")] in the function itself and also in some helper functions Amended some parallelized functions: added cfg_iter_mut macro to simplify some code, deleted unsed parallelization, in intermediate_weights changed chunk size from 64 to r_powers.len() / rayon::current_num_threads() (also tried with thread::available_parallelism but this added more code with no performance improvment found altered code to avoid zero index error Refactor DAS implementation to support various trusted setup sizes / cell sizes Refactor KZGSettings to remove Preset trait Make DAS implementation work with different FIELD_ELEMENTS_PER_EXT_BLOB Remove unused files
Fix formatting Added parallel feature for rust-eth-kzg-benches Added load_trusted_setup benchmarks Fix rust-eth-kzg benchmarks
Added C bindings in eip-7594 Fix constantine tests
Remove unnecessary import Remove unnecessary closures Format files
arkworks implementation eip-7594 fix some errors fix more errors fix remaining ones fix remove remove unused imports try foix make tests pass fix fix again yet another fix fix test
python install build module
|
So the motivation to disable this by default is that potentially |
ArtiomTr
force-pushed
the
Optionally-disable-c-bindings
branch
2 times, most recently
from
500911c to
1d0a945
Compare
ArtiomTr
force-pushed
the
Optionally-disable-c-bindings
branch
from
1d0a945 to
884f7e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
_rawfunctions, that accept raw bytesRelated: grandinetech/grandine#73