Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_widget_attachment_count: Migration to 16.0 (from 12.0) #183

Merged

Conversation

legalsylvain
Copy link
Member

No description provided.

legalsylvain and others added 6 commits January 30, 2025 11:44
… res_id is written after the creation. That can occures in a mail.message.compose context. The attachment is created on the creation of the wizard, but the attachment is related to the item only when the mail is sent
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 97.11538% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.10%. Comparing base (e8cf090) to head (f19a34d).
Report is 14 commits behind head on 16.0.

Files with missing lines Patch % Lines
...eb_widget_attachment_count/models/ir_attachment.py 92.10% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0     #183      +/-   ##
==========================================
+ Coverage   94.31%   95.10%   +0.79%     
==========================================
  Files          32       44      +12     
  Lines         264      368     +104     
  Branches       17       23       +6     
==========================================
+ Hits          249      350     +101     
- Misses         12       13       +1     
- Partials        3        5       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain legalsylvain force-pushed the 16.0-mig-web_widget_attachment_count branch from 7940833 to e7d1fab Compare January 30, 2025 10:53
@legalsylvain legalsylvain force-pushed the 16.0-mig-web_widget_attachment_count branch from e7d1fab to e26dfbf Compare January 30, 2025 11:54
@legalsylvain
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-183-by-legalsylvain-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 89bf589 into grap:16.0 Feb 17, 2025
4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 4c391ce. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants