Small fixes

graphbookai · Nov 15, 2024 · 6883af1 · 6883af1
1 parent 3934507
commit 6883af1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/graphbook/state.py b/graphbook/state.py
@@ -255,8 +255,6 @@ def set_resource_value(resource_id, resource_data):
                 queues[step_id] = MultiConsumerStateDictionaryQueue()
                 step_states[step_id] = set()
                 logger_param_pool[id(step)] = (step_id, step_name)
-                step_graph["parent"][step_id] = set()
-                step_graph["child"][step_id] = set()
 
                 # Remove old consumers from parents
                 previous_obj = self._steps.get(step_id)
@@ -265,6 +263,8 @@ def set_resource_value(resource_id, resource_data):
                     for parent_id in parent_ids:
                         if parent_id in self._queues:
                             self._queues[parent_id].remove_consumer(id(previous_obj))
+            step_graph["parent"][step_id] = set()
+            step_graph["child"][step_id] = set()
 
         # Next, connect the steps
         for step_id, step_data in graph.items():

diff --git a/web/src/components/ContextMenu.tsx b/web/src/components/ContextMenu.tsx
@@ -30,18 +30,21 @@ export function NodeContextMenu({ nodeId, top, left, close }) {
             name: 'Duplicate',
             disabled: () => runState !== 'stopped',
             action: () => {
-                const { addNodes } = reactFlowInstance;
+                const { setNodes } = reactFlowInstance;
                 const position = {
                     x: node.position.x + 50,
                     y: node.position.y + 50,
                 };
 
-                addNodes({
-                    ...node,
-                    selected: false,
-                    dragging: false,
-                    id: `${node.id}-copy`,
-                    position,
+                setNodes(nodes => {
+                    const copy = { ...node } as any;
+                    delete copy.id;
+                    return Graph.addNode({
+                        ...copy,
+                        selected: false,
+                        dragging: false,
+                        position
+                    }, nodes);
                 });
             }
         },

diff --git a/web/src/utils.ts b/web/src/utils.ts
@@ -97,7 +97,9 @@ export const evalDragData = async (reactFlowInstance: ReactFlowInstance, API: Se
                 ...data.node
             };
             Object.values<any>(node.data.parameters).forEach((p) => {
-                p.value = p.default;
+                if (p.default !== undefined) {
+                    p.value = p.default;
+                }
             });
             setNodes(Graph.addNode(node, nodes));
         } else if (data.text) {