Merge pull request #2041 from graphcommerce-org/fix/remove-deprecated

Remove legacyProductRoute functionality from GraphCommerce

.changeset/old-bears-push.md

@@ -0,0 +1,5 @@
+---
+"@graphcommerce/magento-product": major
+---
+
+Removed legacyProductRoute from GraphCommerce

docs/upgrading/graphcommerce-5-to-6.md

@@ -21,9 +21,8 @@ The route for the product has changed from `/product/[url]`,
 `/product/configurable/[url]`, etc. to `/p/[url]` by default. This is a
 singlular product page for all product types.
 
-You can keep using the old behavior by setting
-[legacyProductRoute](../framework/config.md#legacyproductroute-boolean) to true.
-This legacy routing will be removed in a future version.
+~~You can keep using the old behavior by setting `legacyProductRoute` to true.~~
+The legacy routing has been removed in GraphCommerce 8.
 
 You can also change the product route from `/p/[url]` to something else by
 configuring [productRoute](../framework/config.md#productroute-string)

docs/upgrading/graphcommerce-7-to-8.md

@@ -0,0 +1,18 @@
+# Upgrading from GraphCommerce 6 to 7
+
+Depending on the amounts of customisations you've made, there are some manual
+steps. Please follow the regular [upgrade steps first](./readme.md).
+
+1. [`legacyProductRoute` is removed](#legacyproductroute-is-removed)
+2. [Upgrading your Hygraph schema](#upgrading-your-hygraph-schema)
+
+## `legacyProductRoute` is removed
+
+🟠 Only required if you've used the legacyProductRoute
+
+Remove all `/pages/product/*` routes.
+
+## Upgrading your Hygraph schema
+
+Upgrade your Hygraph schema with the [Hygraph migration cli](../hygraph/cli.md).
+Select `graphcommerce7to8` as version.

examples/magento-graphcms/next.config.js

@@ -20,6 +20,9 @@ const nextConfig = {
     maxInactiveAge: 1000 * 60 * 10,
     pagesBufferLength: 10,
   },
+  experimental: {
+    scrollRestoration: true,
+  },
   optimizeFonts: false,
   images: {
     imageSizes: [16, 32, 48, 64, 96, 128, 256, 384],

examples/magento-graphcms/pages/p/[url].tsx

@@ -205,7 +205,6 @@ ProductPage.pageOptions = {
 export default ProductPage
 
 export const getStaticPaths: GetPageStaticPaths = async ({ locales = [] }) => {
-  if (import.meta.graphCommerce.legacyProductRoute) return { paths: [], fallback: false }
   if (process.env.NODE_ENV === 'development') return { paths: [], fallback: 'blocking' }
 
   const path = (locale: string) => getProductStaticPaths(graphqlSsrClient(locale), locale)
@@ -215,8 +214,6 @@ export const getStaticPaths: GetPageStaticPaths = async ({ locales = [] }) => {
 }
 
 export const getStaticProps: GetPageStaticProps = async ({ params, locale }) => {
-  if (import.meta.graphCommerce.legacyProductRoute) return { notFound: true }
-
   const client = graphqlSharedClient(locale)
   const staticClient = graphqlSsrClient(locale)