Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gcom 1229 support all customizable options #2099

Merged
merged 34 commits into from
Jan 4, 2024

Conversation

Jessevdpoel
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 53d6eca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages
Name Type
@graphcommerce/magento-product-configurable Major
@graphcommerce/magento-product-virtual Major
@graphcommerce/magento-product-bundle Major
@graphcommerce/magento-product-simple Major
@graphcommerce/magento-cart-items Major
@graphcommerce/googleanalytics Major
@graphcommerce/magento-product Major
@graphcommerce/demo-magento-graphcommerce Major
@graphcommerce/magento-payment-braintree Major
@graphcommerce/magento-payment-included Major
@graphcommerce/magento-payment-multisafepay Major
@graphcommerce/magento-recently-viewed-products Major
@graphcommerce/magento-wishlist Major
@graphcommerce/mollie-magento-payment Major
@graphcommerce/magento-graphcms Major
@graphcommerce/magento-product-grouped Major
@graphcommerce/magento-cart-checkout Major
@graphcommerce/algolia-search Major
@graphcommerce/magento-cart-email Major
@graphcommerce/magento-category Major
@graphcommerce/magento-compare Major
@graphcommerce/magento-pagebuilder Major
@graphcommerce/magento-payment-adyen Major
@graphcommerce/magento-product-downloadable Major
@graphcommerce/magento-review Major
@graphcommerce/magento-search Major
@graphcommerce/docs Major
@graphcommerce/browserslist-config-pwa Major
@graphcommerce/changeset-changelog Major
@graphcommerce/eslint-config-pwa Major
@graphcommerce/graphql-codegen-markdown-docs Major
@graphcommerce/graphql-codegen-near-operation-file Major
@graphcommerce/graphql-codegen-relay-optimizer-plugin Major
@graphcommerce/next-config Major
@graphcommerce/prettier-config-pwa Major
@graphcommerce/typescript-config-pwa Major
@graphcommerce/address-fields-nl Major
@graphcommerce/cli Major
@graphcommerce/ecommerce-ui Major
@graphcommerce/framer-next-pages Major
@graphcommerce/framer-scroller Major
@graphcommerce/framer-utils Major
@graphcommerce/googlerecaptcha Major
@graphcommerce/googletagmanager Major
@graphcommerce/graphql-mesh Major
@graphcommerce/graphql Major
@graphcommerce/hygraph-cli Major
@graphcommerce/hygraph-dynamic-rows-ui Major
@graphcommerce/hygraph-dynamic-rows Major
@graphcommerce/graphcms-ui Major
@graphcommerce/image Major
@graphcommerce/lighthouse Major
@graphcommerce/lingui-next Major
@graphcommerce/magento-cart-billing-address Major
@graphcommerce/magento-cart-coupon Major
@graphcommerce/magento-cart-payment-method Major
@graphcommerce/magento-cart-pickup Major
@graphcommerce/magento-cart-shipping-address Major
@graphcommerce/magento-cart-shipping-method Major
@graphcommerce/magento-cart Major
@graphcommerce/magento-cms Major
@graphcommerce/magento-customer-account Major
@graphcommerce/magento-customer-order Major
@graphcommerce/magento-customer Major
@graphcommerce/magento-graphql Major
@graphcommerce/magento-newsletter Major
@graphcommerce/magento-payment-klarna Major
@graphcommerce/magento-payment-paypal Major
@graphcommerce/magento-store Major
@graphcommerce/next-ui Major
@graphcommerce/react-hook-form Major
@graphcommerce/framer-next-pages-example Major
@graphcommerce/framer-scroller-example Major
@graphcommerce/image-example Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ✅ Ready (Inspect) Visit Preview Jan 4, 2024 1:12pm
graphcommerce-hygraph-dynamic-rows-ui ✅ Ready (Inspect) Visit Preview Jan 4, 2024 1:12pm

Copy link
Contributor

@JoshuaS98 JoshuaS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jessevdpoel Jessevdpoel requested a review from paales November 29, 2023 15:20
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/cart 3.4kB 3.5kB 0.1kB 297kB 285.0kB -12kB🔥
/checkout/payment 12.3kB 12.4kB 0.1kB 290kB 290.0kB
/checkout/success 7.2kB 7.3kB 0.1kB 293kB 281.0kB -12kB🔥
/p/[url] 10.2kB 15.5kB +5.3kB🚨 335kB 337.0kB +2kB⚠️
/product/configurable/[url] 6.2kB 6.9kB 0.7kB 330kB 330.0kB
/service/[[...url]] 5.8kB 5.8kB 273kB 274.0kB +1kB⚠️

Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/cart 3.4kB 3.5kB 0.1kB 297kB 285.0kB -12kB🔥
/checkout/payment 12.3kB 12.4kB 0.1kB 290kB 290.0kB
/checkout/success 7.2kB 7.3kB 0.1kB 293kB 281.0kB -12kB🔥
/p/[url] 10.2kB 15.5kB +5.3kB🚨 335kB 337.0kB +2kB⚠️
/product/configurable/[url] 6.2kB 6.9kB 0.7kB 330kB 330.0kB
/service/[[...url]] 5.8kB 5.8kB 273kB 274.0kB +1kB⚠️

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Page Size old Size new Size diff First load old First load new First load diff
/cart 3.4kB 3.5kB 0.1kB 297kB 285.0kB -12kB🔥
/checkout/payment 12.3kB 12.4kB 0.1kB 290kB 290.0kB
/checkout/success 7.2kB 7.3kB 0.1kB 293kB 281.0kB -12kB🔥
/p/[url] 10.2kB 15.5kB +5.3kB🚨 335kB 337.0kB +2kB⚠️
/product/configurable/[url] 6.2kB 6.9kB 0.7kB 330kB 330.0kB
/service/[[...url]] 5.8kB 5.8kB 273kB 274.0kB +1kB⚠️

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 11.5kB 11.4kB -0.1kB 282kB 282.0kB
/cart 3.4kB 3.6kB 0.2kB 315kB 304.0kB -11kB🔥
/checkout/payment 15.4kB 15.5kB 0.1kB 290kB 290.0kB
/checkout/success 5.3kB 5.4kB 0.1kB 293kB 281.0kB -12kB🔥
/p/[url] 16.8kB 21.6kB +4.8kB⚠️ 333kB 335.0kB +2kB⚠️
/test/icons 7.2kB 7.1kB -0.1kB 223kB 223.0kB

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 11.5kB 11.4kB -0.1kB 282kB 282.0kB
/cart 3.4kB 3.6kB 0.2kB 315kB 304.0kB -11kB🔥
/checkout/payment 15.4kB 15.5kB 0.1kB 290kB 290.0kB
/checkout/success 5.3kB 5.4kB 0.1kB 293kB 281.0kB -12kB🔥
/p/[url] 16.8kB 21.6kB +4.8kB⚠️ 333kB 335.0kB +2kB⚠️
/test/icons 7.2kB 7.1kB -0.1kB 223kB 223.0kB

@paales paales merged commit 40f167d into canary Jan 4, 2024
4 checks passed
@paales paales deleted the feature/GCOM-1229-support-all-customizable-options branch January 4, 2024 13:14
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Page Size old Size new Size diff First load old First load new First load diff
/account/signin 11.5kB 11.4kB -0.1kB 282kB 282.0kB
/cart 3.4kB 3.6kB 0.2kB 315kB 304.0kB -11kB🔥
/checkout/payment 15.4kB 15.5kB 0.1kB 290kB 290.0kB
/checkout/success 5.3kB 5.4kB 0.1kB 293kB 281.0kB -12kB🔥
/p/[url] 16.8kB 21.6kB +4.8kB⚠️ 333kB 335.0kB +2kB⚠️
/test/icons 7.2kB 7.1kB -0.1kB 223kB 223.0kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants