Fix/hydration on intersection (GCOM-1056) #2133

Jessevdpoel · 2023-11-30T10:05:55Z

No description provided.

changeset-bot · 2023-11-30T10:05:59Z

🦋 Changeset detected

Latest commit: 5e1e234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages

Name	Type
@graphcommerce/magento-product	Major
@graphcommerce/next-ui	Major
@graphcommerce/algolia-search	Major
@graphcommerce/demo-magento-graphcommerce	Major
@graphcommerce/googleanalytics	Major
@graphcommerce/magento-cart-email	Major
@graphcommerce/magento-cart-items	Major
@graphcommerce/magento-category	Major
@graphcommerce/magento-compare	Major
@graphcommerce/magento-pagebuilder	Major
@graphcommerce/magento-payment-adyen	Major
@graphcommerce/magento-payment-braintree	Major
@graphcommerce/magento-payment-included	Major
@graphcommerce/magento-payment-multisafepay	Major
@graphcommerce/magento-product-bundle	Major
@graphcommerce/magento-product-configurable	Major
@graphcommerce/magento-product-downloadable	Major
@graphcommerce/magento-product-grouped	Major
@graphcommerce/magento-product-simple	Major
@graphcommerce/magento-product-virtual	Major
@graphcommerce/magento-recently-viewed-products	Major
@graphcommerce/magento-review	Major
@graphcommerce/magento-search	Major
@graphcommerce/magento-wishlist	Major
@graphcommerce/mollie-magento-payment	Major
@graphcommerce/magento-graphcms	Major
@graphcommerce/address-fields-nl	Major
@graphcommerce/ecommerce-ui	Major
@graphcommerce/googlerecaptcha	Major
@graphcommerce/googletagmanager	Major
@graphcommerce/hygraph-dynamic-rows	Major
@graphcommerce/graphcms-ui	Major
@graphcommerce/lingui-next	Major
@graphcommerce/magento-cart-billing-address	Major
@graphcommerce/magento-cart-checkout	Major
@graphcommerce/magento-cart-coupon	Major
@graphcommerce/magento-cart-payment-method	Major
@graphcommerce/magento-cart-pickup	Major
@graphcommerce/magento-cart-shipping-address	Major
@graphcommerce/magento-cart-shipping-method	Major
@graphcommerce/magento-cart	Major
@graphcommerce/magento-customer-order	Major
@graphcommerce/magento-customer	Major
@graphcommerce/magento-newsletter	Major
@graphcommerce/magento-payment-klarna	Major
@graphcommerce/magento-payment-paypal	Major
@graphcommerce/magento-store	Major
@graphcommerce/magento-customer-account	Major
@graphcommerce/magento-cms	Major
@graphcommerce/docs	Major
@graphcommerce/browserslist-config-pwa	Major
@graphcommerce/changeset-changelog	Major
@graphcommerce/eslint-config-pwa	Major
@graphcommerce/graphql-codegen-markdown-docs	Major
@graphcommerce/graphql-codegen-near-operation-file	Major
@graphcommerce/graphql-codegen-relay-optimizer-plugin	Major
@graphcommerce/next-config	Major
@graphcommerce/prettier-config-pwa	Major
@graphcommerce/typescript-config-pwa	Major
@graphcommerce/cli	Major
@graphcommerce/framer-next-pages	Major
@graphcommerce/framer-scroller	Major
@graphcommerce/framer-utils	Major
@graphcommerce/graphql-mesh	Major
@graphcommerce/graphql	Major
@graphcommerce/hygraph-cli	Major
@graphcommerce/hygraph-dynamic-rows-ui	Major
@graphcommerce/image	Major
@graphcommerce/lighthouse	Major
@graphcommerce/magento-graphql	Major
@graphcommerce/react-hook-form	Major
@graphcommerce/framer-next-pages-example	Major
@graphcommerce/framer-scroller-example	Major
@graphcommerce/image-example	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-11-30T10:06:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
graphcommerce	✅ Ready (Inspect)	Visit Preview	Jan 5, 2024 1:18pm
graphcommerce-hygraph-dynamic-rows-ui	✅ Ready (Inspect)	Visit Preview	Jan 5, 2024 1:18pm

examples/magento-graphcms/components/Layout/LayoutNavigation.tsx

… MotionValue

This reverts commit 49dae02.

…d on the client

github-actions · 2024-01-05T10:39:53Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/	3.1kB	3.1kB		291kB	292.0kB	+1kB⚠️
/[...url]	3.1kB	3.1kB		315kB	316.0kB	+1kB⚠️
/404	6.0kB	6.3kB	0.3kB	239kB	240.0kB	+1kB⚠️
/account	10.3kB	10.6kB	0.3kB	245kB	246.0kB	+1kB⚠️
/blog	0.8kB	0.8kB		292kB	293.0kB	+1kB⚠️
/blog/page/[page]	0.8kB	0.8kB		292kB	293.0kB	+1kB⚠️
/c/[...url]	3.2kB	3.2kB		315kB	316.0kB	+1kB⚠️
/checkout	12.8kB	13.1kB	0.3kB	275kB	275.0kB
/checkout/success	5.4kB	5.4kB		281kB	282.0kB	+1kB⚠️
/modal/[...url]	5.9kB	5.9kB		273kB	274.0kB	+1kB⚠️
/service/[[...url]]	5.8kB	5.8kB		273kB	274.0kB	+1kB⚠️
/test/[[...url]]	4.3kB	4.6kB	0.3kB	244kB	245.0kB	+1kB⚠️
/test/buttons	7.5kB	7.8kB	0.3kB	217kB	217.0kB
/test/icons	7.1kB	7.5kB	0.4kB	223kB	223.0kB
/test/minimal-page-shell/[[...url]]	8.3kB	8.7kB	0.4kB	218kB	218.0kB
/test/number-inputs	7.8kB	8.1kB	0.3kB	250kB	250.0kB
/test/slider	7.0kB	7.3kB	0.3kB	247kB	247.0kB
/test/typography	6.9kB	7.3kB	0.4kB	216kB	217.0kB	+1kB⚠️
/test/usebacklink/[[...url]]	6.3kB	6.6kB	0.3kB	209kB	209.0kB

github-actions · 2024-01-05T13:17:44Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/	3.1kB	3.1kB		291kB	292.0kB	+1kB⚠️
/[...url]	3.1kB	3.1kB		315kB	316.0kB	+1kB⚠️
/404	6.0kB	6.3kB	0.3kB	239kB	240.0kB	+1kB⚠️
/account	10.3kB	10.6kB	0.3kB	245kB	246.0kB	+1kB⚠️
/blog	0.8kB	0.8kB		292kB	293.0kB	+1kB⚠️
/blog/page/[page]	0.8kB	0.8kB		292kB	293.0kB	+1kB⚠️
/c/[...url]	3.2kB	3.2kB		315kB	316.0kB	+1kB⚠️
/checkout	12.8kB	13.1kB	0.3kB	275kB	275.0kB
/checkout/success	5.4kB	5.4kB		281kB	282.0kB	+1kB⚠️
/modal/[...url]	5.9kB	5.9kB		273kB	274.0kB	+1kB⚠️
/service/[[...url]]	5.8kB	5.8kB		273kB	274.0kB	+1kB⚠️
/test/[[...url]]	4.3kB	4.6kB	0.3kB	244kB	245.0kB	+1kB⚠️
/test/buttons	7.5kB	7.8kB	0.3kB	217kB	217.0kB
/test/icons	7.1kB	7.5kB	0.4kB	223kB	223.0kB
/test/minimal-page-shell/[[...url]]	8.3kB	8.6kB	0.3kB	218kB	218.0kB
/test/number-inputs	7.8kB	8.1kB	0.3kB	250kB	250.0kB
/test/slider	7.0kB	7.3kB	0.3kB	247kB	247.0kB
/test/typography	6.9kB	7.2kB	0.3kB	216kB	217.0kB	+1kB⚠️
/test/usebacklink/[[...url]]	6.3kB	6.6kB	0.3kB	209kB	209.0kB

github-actions · 2024-01-05T13:20:35Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/	3.1kB	3.1kB		291kB	292.0kB	+1kB⚠️
/[...url]	3.1kB	3.1kB		315kB	316.0kB	+1kB⚠️
/404	6.0kB	6.3kB	0.3kB	239kB	240.0kB	+1kB⚠️
/account	10.3kB	10.6kB	0.3kB	245kB	246.0kB	+1kB⚠️
/blog	0.8kB	0.8kB		292kB	293.0kB	+1kB⚠️
/blog/page/[page]	0.8kB	0.8kB		292kB	293.0kB	+1kB⚠️
/c/[...url]	3.2kB	3.2kB		315kB	316.0kB	+1kB⚠️
/checkout	12.8kB	13.1kB	0.3kB	275kB	275.0kB
/checkout/success	5.4kB	5.4kB		281kB	282.0kB	+1kB⚠️
/modal/[...url]	5.9kB	5.9kB		273kB	274.0kB	+1kB⚠️
/service/[[...url]]	5.8kB	5.8kB		273kB	274.0kB	+1kB⚠️
/test/[[...url]]	4.3kB	4.6kB	0.3kB	244kB	245.0kB	+1kB⚠️
/test/buttons	7.5kB	7.8kB	0.3kB	217kB	217.0kB
/test/icons	7.1kB	7.5kB	0.4kB	223kB	223.0kB
/test/minimal-page-shell/[[...url]]	8.3kB	8.6kB	0.3kB	218kB	218.0kB
/test/number-inputs	7.8kB	8.1kB	0.3kB	250kB	250.0kB
/test/slider	7.0kB	7.2kB	0.2kB	247kB	247.0kB
/test/typography	6.9kB	7.2kB	0.3kB	216kB	217.0kB	+1kB⚠️
/test/usebacklink/[[...url]]	6.3kB	6.6kB	0.3kB	209kB	209.0kB

This comment was marked as outdated.

Sign in to view

paales changed the title ~~Fix/hydration on intersection gcom 1056~~ Fix/hydration on intersection (GCOM-1056) Dec 4, 2023

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 4, 2023 10:20 View deployment

vercel bot deployed to Preview – graphcommerce December 4, 2023 10:22 View deployment

This comment was marked as outdated.

Sign in to view

paales requested changes Dec 4, 2023

View reviewed changes

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 4, 2023 12:33 View deployment

vercel bot deployed to Preview – graphcommerce December 4, 2023 12:36 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 4, 2023 13:54 View deployment

vercel bot deployed to Preview – graphcommerce December 4, 2023 13:56 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 4, 2023 14:55 View deployment

vercel bot deployed to Preview – graphcommerce December 4, 2023 14:57 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 4, 2023 15:08 View deployment

vercel bot deployed to Preview – graphcommerce December 4, 2023 15:11 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 4, 2023 15:19 View deployment

vercel bot deployed to Preview – graphcommerce December 4, 2023 15:21 View deployment

This comment was marked as outdated.

Sign in to view

Jessevdpoel requested a review from paales December 5, 2023 11:01

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 5, 2023 11:01 View deployment

vercel bot deployed to Preview – graphcommerce December 5, 2023 11:03 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 5, 2023 13:06 View deployment

vercel bot had a problem deploying to Preview – graphcommerce December 5, 2023 13:07 Failure

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui December 5, 2023 14:34 View deployment

Jessevdpoel and others added 9 commits January 5, 2024 10:02

Moved lazyHydration to ProductPageDescription

2213964

removed unused import

3839faf

Added changeset

133f908

lazy hydrate menu

75b8541

Refactored LazyHydrate, removed hold prop and added a hydrateManually…

a62d7ce

… MotionValue

observer test

85b202d

bugfix for megamenu opening after navigating

d0b2a74

Revert "bugfix for megamenu opening after navigating"

a5801e0

This reverts commit 49dae02.

Disable LazyHydrate for menu

85894d5

paales force-pushed the fix/hydration-on-intersection-GCOM-1056 branch from 555f98a to 85894d5 Compare January 5, 2024 09:03

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 5, 2024 09:04 View deployment

vercel bot deployed to Preview – graphcommerce January 5, 2024 09:06 View deployment

This comment was marked as outdated.

Sign in to view

Refactor LazyHydrate to be simpler

78fb45c

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 5, 2024 10:18 View deployment

vercel bot deployed to Preview – graphcommerce January 5, 2024 10:20 View deployment

This comment was marked as outdated.

Sign in to view

Disable the hydration warning if the component is immediately rendere…

b53caae

…d on the client

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 5, 2024 10:34 View deployment

vercel bot deployed to Preview – graphcommerce January 5, 2024 10:36 View deployment

Simplify LazyHydrate

367ce9c

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 5, 2024 13:13 View deployment

Simplify LazyHydrate 2

5e1e234

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 5, 2024 13:15 View deployment

vercel bot deployed to Preview – graphcommerce January 5, 2024 13:18 View deployment

paales merged commit ec25134 into canary Jan 5, 2024
4 checks passed

paales deleted the fix/hydration-on-intersection-GCOM-1056 branch January 5, 2024 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/hydration on intersection (GCOM-1056) #2133

Fix/hydration on intersection (GCOM-1056) #2133

Jessevdpoel commented Nov 30, 2023

changeset-bot bot commented Nov 30, 2023 •

edited

Loading

vercel bot commented Nov 30, 2023 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

Fix/hydration on intersection (GCOM-1056) #2133

Fix/hydration on intersection (GCOM-1056) #2133

Conversation

Jessevdpoel commented Nov 30, 2023

changeset-bot bot commented Nov 30, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Nov 30, 2023 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

changeset-bot bot commented Nov 30, 2023 •

edited

Loading

vercel bot commented Nov 30, 2023 •

edited

Loading