Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove variants field on product listing to improve perf (GCOM-1213) #2152

Closed
wants to merge 11 commits into from
Closed

Remove variants field on product listing to improve perf (GCOM-1213) #2152

wants to merge 11 commits into from

Conversation

Jessevdpoel
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: cfbd817

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages
Name Type
@graphcommerce/magento-product-configurable Major
@graphcommerce/magento-product Major
@graphcommerce/demo-magento-graphcommerce Major
@graphcommerce/magento-payment-braintree Major
@graphcommerce/magento-payment-included Major
@graphcommerce/magento-payment-multisafepay Major
@graphcommerce/magento-recently-viewed-products Major
@graphcommerce/magento-wishlist Major
@graphcommerce/mollie-magento-payment Major
@graphcommerce/magento-graphcms Major
@graphcommerce/algolia-search Major
@graphcommerce/googleanalytics Major
@graphcommerce/magento-cart-email Major
@graphcommerce/magento-cart-items Major
@graphcommerce/magento-category Major
@graphcommerce/magento-compare Major
@graphcommerce/magento-pagebuilder Major
@graphcommerce/magento-payment-adyen Major
@graphcommerce/magento-product-bundle Major
@graphcommerce/magento-product-downloadable Major
@graphcommerce/magento-product-grouped Major
@graphcommerce/magento-product-simple Major
@graphcommerce/magento-product-virtual Major
@graphcommerce/magento-review Major
@graphcommerce/magento-search Major
@graphcommerce/magento-cart-checkout Major
@graphcommerce/docs Major
@graphcommerce/browserslist-config-pwa Major
@graphcommerce/changeset-changelog Major
@graphcommerce/eslint-config-pwa Major
@graphcommerce/graphql-codegen-markdown-docs Major
@graphcommerce/graphql-codegen-near-operation-file Major
@graphcommerce/graphql-codegen-relay-optimizer-plugin Major
@graphcommerce/next-config Major
@graphcommerce/prettier-config-pwa Major
@graphcommerce/typescript-config-pwa Major
@graphcommerce/address-fields-nl Major
@graphcommerce/cli Major
@graphcommerce/ecommerce-ui Major
@graphcommerce/framer-next-pages Major
@graphcommerce/framer-scroller Major
@graphcommerce/framer-utils Major
@graphcommerce/googlerecaptcha Major
@graphcommerce/googletagmanager Major
@graphcommerce/graphql-mesh Major
@graphcommerce/graphql Major
@graphcommerce/hygraph-cli Major
@graphcommerce/hygraph-dynamic-rows-ui Major
@graphcommerce/hygraph-dynamic-rows Major
@graphcommerce/graphcms-ui Major
@graphcommerce/image Major
@graphcommerce/lighthouse Major
@graphcommerce/lingui-next Major
@graphcommerce/magento-cart-billing-address Major
@graphcommerce/magento-cart-coupon Major
@graphcommerce/magento-cart-payment-method Major
@graphcommerce/magento-cart-pickup Major
@graphcommerce/magento-cart-shipping-address Major
@graphcommerce/magento-cart-shipping-method Major
@graphcommerce/magento-cart Major
@graphcommerce/magento-cms Major
@graphcommerce/magento-customer-account Major
@graphcommerce/magento-customer-order Major
@graphcommerce/magento-customer Major
@graphcommerce/magento-graphql Major
@graphcommerce/magento-newsletter Major
@graphcommerce/magento-payment-klarna Major
@graphcommerce/magento-payment-paypal Major
@graphcommerce/magento-store Major
@graphcommerce/next-ui Major
@graphcommerce/react-hook-form Major
@graphcommerce/framer-next-pages-example Major
@graphcommerce/framer-scroller-example Major
@graphcommerce/image-example Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ✅ Ready (Inspect) Visit Preview Jan 3, 2024 10:29am
graphcommerce-hygraph-dynamic-rows-ui ✅ Ready (Inspect) Visit Preview Jan 3, 2024 10:29am

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/[...url] 3.1kB 3.1kB 316kB 317.0kB +1kB⚠️
/c/[...url] 3.2kB 3.2kB 316kB 317.0kB +1kB⚠️
/compare 9.3kB 9.2kB -0.1kB 283kB 284.0kB +1kB⚠️
/newsletter 6.1kB 6.1kB 298kB 299.0kB +1kB⚠️
/p/[url] 10.2kB 10.2kB 335kB 336.0kB +1kB⚠️
/product/configurable/[url] 6.2kB 6.2kB 330kB 331.0kB +1kB⚠️
/product/downloadable/[url] 1.4kB 1.4kB 328kB 329.0kB +1kB⚠️
/product/grouped/[url] 1.4kB 1.4kB 328kB 329.0kB +1kB⚠️
/product/virtual/[url] 1.3kB 1.3kB 328kB 329.0kB +1kB⚠️
/search 4.3kB 4.3kB 323kB 324.0kB +1kB⚠️
/search/[...url] 4.4kB 4.4kB 323kB 324.0kB +1kB⚠️
/service/[[...url]] 5.8kB 5.8kB 273kB 274.0kB +1kB⚠️
/test/slider 7.0kB 7.0kB 248kB 247.0kB -1kB

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/[...url] 3.1kB 3.2kB 0.1kB 316kB 316.0kB
/blog/[url] 1.6kB 1.6kB 294kB 293.0kB -1kB
/blog/tagged/[url] 1.6kB 1.6kB 294kB 293.0kB -1kB
/c/[...url] 3.2kB 3.3kB 0.1kB 316kB 316.0kB
/checkout/added 7.5kB 7.5kB 254kB 253.0kB -1kB
/compare 9.3kB 9.2kB -0.1kB 283kB 283.0kB
/modal/[...url] 5.8kB 5.8kB 274kB 273.0kB -1kB
/test/slider 7.0kB 7.0kB 248kB 247.0kB -1kB

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/[...url] 3.1kB 3.2kB 0.1kB 316kB 316.0kB
/blog/[url] 1.6kB 1.6kB 294kB 293.0kB -1kB
/blog/tagged/[url] 1.6kB 1.6kB 294kB 293.0kB -1kB
/c/[...url] 3.2kB 3.3kB 0.1kB 316kB 316.0kB
/checkout/added 7.5kB 7.5kB 254kB 253.0kB -1kB
/compare 9.3kB 9.2kB -0.1kB 283kB 283.0kB
/modal/[...url] 5.8kB 5.8kB 274kB 273.0kB -1kB
/test/slider 7.0kB 7.0kB 248kB 247.0kB -1kB

@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/blog/[url] 1.6kB 1.6kB 294kB 293.0kB -1kB
/blog/tagged/[url] 1.6kB 1.6kB 294kB 293.0kB -1kB
/checkout/added 7.5kB 7.5kB 254kB 253.0kB -1kB
/compare 9.3kB 9.2kB -0.1kB 283kB 283.0kB
/modal/[...url] 5.8kB 5.8kB 274kB 273.0kB -1kB
/test/slider 7.0kB 7.0kB 248kB 247.0kB -1kB

@Jessevdpoel Jessevdpoel requested a review from JoshuaS98 January 3, 2024 10:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Page Size old Size new Size diff First load old First load new First load diff
/[...url] 3.1kB 3.1kB 316kB 315.0kB -1kB
/c/[...url] 3.2kB 3.2kB 316kB 315.0kB -1kB
/compare 9.3kB 9.2kB -0.1kB 283kB 282.0kB -1kB
/newsletter 6.1kB 6.1kB 298kB 297.0kB -1kB
/p/[url] 10.1kB 10.1kB 335kB 334.0kB -1kB
/product/configurable/[url] 6.2kB 6.2kB 330kB 329.0kB -1kB
/product/downloadable/[url] 1.4kB 1.4kB 328kB 327.0kB -1kB
/product/grouped/[url] 1.4kB 1.4kB 328kB 327.0kB -1kB
/product/virtual/[url] 1.3kB 1.3kB 328kB 327.0kB -1kB
/search 4.3kB 4.3kB 323kB 322.0kB -1kB
/wishlist 7.0kB 7.0kB 276kB 275.0kB -1kB

JoshuaS98
JoshuaS98 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@JoshuaS98 JoshuaS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jessevdpoel Jessevdpoel requested a review from paales January 8, 2024 09:29
@paales paales changed the title Feature/remove variants from list gcom 1213 Feature/remove variants from list (GCOM-1213) Jan 15, 2024
@paales paales changed the title Feature/remove variants from list (GCOM-1213) Remove variants field on product listing to improve perf (GCOM-1213) Jan 15, 2024
@paales paales closed this Jun 28, 2024
@paales paales deleted the feature/remove-variants-from-list-GCOM-1213 branch December 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaS98 JoshuaS98 JoshuaS98 approved these changes

@bramvanderholst bramvanderholst Awaiting requested review from bramvanderholst

@paales paales Awaiting requested review from paales

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jessevdpoel @JoshuaS98 @paales