Refactor GA4 / GTM tracking preferences (GCOM-1312) #2158

mikekeehnen · 2024-01-04T11:37:21Z

No description provided.

changeset-bot · 2024-01-04T11:37:24Z

🦋 Changeset detected

Latest commit: 429616c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 75 packages

Name	Type
@graphcommerce/google-datalayer	Patch
@graphcommerce/googletagmanager	Patch
@graphcommerce/googleanalytics	Patch
@graphcommerce/magento-graphcms	Patch
@graphcommerce/docs	Patch
@graphcommerce/browserslist-config-pwa	Patch
@graphcommerce/changeset-changelog	Patch
@graphcommerce/eslint-config-pwa	Patch
@graphcommerce/graphql-codegen-markdown-docs	Patch
@graphcommerce/graphql-codegen-near-operation-file	Patch
@graphcommerce/graphql-codegen-relay-optimizer-plugin	Patch
@graphcommerce/next-config	Patch
@graphcommerce/prettier-config-pwa	Patch
@graphcommerce/typescript-config-pwa	Patch
@graphcommerce/address-fields-nl	Patch
@graphcommerce/algolia-search	Patch
@graphcommerce/cli	Patch
@graphcommerce/demo-magento-graphcommerce	Patch
@graphcommerce/ecommerce-ui	Patch
@graphcommerce/framer-next-pages	Patch
@graphcommerce/framer-scroller	Patch
@graphcommerce/framer-utils	Patch
@graphcommerce/googlerecaptcha	Patch
@graphcommerce/graphql-mesh	Patch
@graphcommerce/graphql	Patch
@graphcommerce/hygraph-cli	Patch
@graphcommerce/hygraph-dynamic-rows-ui	Patch
@graphcommerce/hygraph-dynamic-rows	Patch
@graphcommerce/graphcms-ui	Patch
@graphcommerce/image	Patch
@graphcommerce/lighthouse	Patch
@graphcommerce/lingui-next	Patch
@graphcommerce/magento-cart-billing-address	Patch
@graphcommerce/magento-cart-checkout	Patch
@graphcommerce/magento-cart-coupon	Patch
@graphcommerce/magento-cart-email	Patch
@graphcommerce/magento-cart-items	Patch
@graphcommerce/magento-cart-payment-method	Patch
@graphcommerce/magento-cart-pickup	Patch
@graphcommerce/magento-cart-shipping-address	Patch
@graphcommerce/magento-cart-shipping-method	Patch
@graphcommerce/magento-cart	Patch
@graphcommerce/magento-category	Patch
@graphcommerce/magento-cms	Patch
@graphcommerce/magento-compare	Patch
@graphcommerce/magento-customer-account	Patch
@graphcommerce/magento-customer-order	Patch
@graphcommerce/magento-customer	Patch
@graphcommerce/magento-graphql	Patch
@graphcommerce/magento-newsletter	Patch
@graphcommerce/magento-pagebuilder	Patch
@graphcommerce/magento-payment-adyen	Patch
@graphcommerce/magento-payment-braintree	Patch
@graphcommerce/magento-payment-included	Patch
@graphcommerce/magento-payment-klarna	Patch
@graphcommerce/magento-payment-multisafepay	Patch
@graphcommerce/magento-payment-paypal	Patch
@graphcommerce/magento-product-bundle	Patch
@graphcommerce/magento-product-configurable	Patch
@graphcommerce/magento-product-downloadable	Patch
@graphcommerce/magento-product-grouped	Patch
@graphcommerce/magento-product-simple	Patch
@graphcommerce/magento-product-virtual	Patch
@graphcommerce/magento-product	Patch
@graphcommerce/magento-recently-viewed-products	Patch
@graphcommerce/magento-review	Patch
@graphcommerce/magento-search	Patch
@graphcommerce/magento-store	Patch
@graphcommerce/magento-wishlist	Patch
@graphcommerce/mollie-magento-payment	Patch
@graphcommerce/next-ui	Patch
@graphcommerce/react-hook-form	Patch
@graphcommerce/framer-next-pages-example	Patch
@graphcommerce/framer-scroller-example	Patch
@graphcommerce/image-example	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-01-04T11:37:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
graphcommerce	✅ Ready (Inspect)	Visit Preview	Mar 27, 2024 11:31am
graphcommerce-hygraph-dynamic-rows-ui	✅ Ready (Inspect)	Visit Preview	Mar 27, 2024 11:31am

Giovanni-Schroevers · 2024-02-23T15:01:05Z

@mikekeehnen Could you make all the fragments used in analytics injectable?

packages/analytics/package.json

packages/analytics/Config.graphqls

packages/analytics/README.md

packages/analytics/plugins/ViewItem.tsx

packages/analytics/events/index.ts

github-actions · 2024-03-26T12:30:44Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/[...url]	3.2kB	3.1kB	-0.1kB	318kB	318.0kB
/404	6.0kB	6.0kB		241kB	242.0kB	+1kB⚠️
/account	10.6kB	10.6kB		246kB	247.0kB	+1kB⚠️
/account/addresses/add	7.6kB	7.6kB		271kB	272.0kB	+1kB⚠️
/account/authentication	7.6kB	7.6kB		268kB	269.0kB	+1kB⚠️
/account/contact	7.8kB	7.8kB		268kB	269.0kB	+1kB⚠️
/account/orders	7.2kB	7.2kB		246kB	247.0kB	+1kB⚠️
/account/reviews/add	7.4kB	7.4kB		266kB	267.0kB	+1kB⚠️
/checkout/customer/addresses/edit	5.8kB	5.7kB	-0.1kB	272kB	272.0kB
/compare	9.5kB	9.5kB		284kB	285.0kB	+1kB⚠️
/modal/[...url]	6.2kB	6.2kB		274kB	275.0kB	+1kB⚠️
/p/[url]	21.7kB	21.7kB		337kB	338.0kB	+1kB⚠️
/test/buttons	5.1kB	5.1kB		219kB	218.0kB	-1kB
/test/icons	4.7kB	4.9kB	0.2kB	225kB	225.0kB
/test/slider	7.0kB	7.0kB		249kB	250.0kB	+1kB⚠️

github-actions · 2024-03-26T13:28:13Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/[...url]	3.2kB	3.1kB	-0.1kB	318kB	318.0kB
/404	6.0kB	6.0kB		241kB	242.0kB	+1kB⚠️
/account	10.6kB	10.6kB		246kB	247.0kB	+1kB⚠️
/account/addresses/add	7.6kB	7.6kB		271kB	272.0kB	+1kB⚠️
/account/authentication	7.6kB	7.6kB		268kB	269.0kB	+1kB⚠️
/account/contact	7.8kB	7.8kB		268kB	269.0kB	+1kB⚠️
/account/orders	7.2kB	7.2kB		246kB	247.0kB	+1kB⚠️
/account/reviews/add	7.4kB	7.4kB		266kB	267.0kB	+1kB⚠️
/checkout/customer/addresses/edit	5.8kB	5.7kB	-0.1kB	272kB	272.0kB
/compare	9.5kB	9.5kB		284kB	285.0kB	+1kB⚠️
/modal/[...url]	6.2kB	6.2kB		274kB	275.0kB	+1kB⚠️
/p/[url]	21.7kB	21.7kB		337kB	338.0kB	+1kB⚠️
/test/buttons	5.1kB	5.1kB		219kB	218.0kB	-1kB
/test/icons	4.7kB	4.9kB	0.2kB	225kB	225.0kB
/test/slider	7.0kB	7.0kB		249kB	250.0kB	+1kB⚠️

github-actions · 2024-03-26T15:16:02Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/	3.1kB	3.5kB	0.4kB	294kB	299.0kB	+5kB🚨
/[...url]	3.2kB	3.2kB		318kB	322.0kB	+4kB⚠️
/404	6.0kB	6.1kB	0.1kB	241kB	247.0kB	+6kB🚨
/account	10.6kB	10.6kB		246kB	247.0kB	+1kB⚠️
/account/addresses/add	7.6kB	7.6kB		271kB	272.0kB	+1kB⚠️
/account/addresses/edit	0.8kB	0.8kB		272kB	273.0kB	+1kB⚠️
/account/authentication	7.6kB	7.6kB		268kB	269.0kB	+1kB⚠️
/account/contact	7.8kB	7.8kB		268kB	269.0kB	+1kB⚠️
/account/forgot-password	5.2kB	5.2kB		261kB	262.0kB	+1kB⚠️
/account/orders	7.2kB	7.2kB		246kB	247.0kB	+1kB⚠️
/account/reviews/add	7.4kB	7.4kB		266kB	267.0kB	+1kB⚠️
/blog	0.8kB	1.5kB	0.7kB	295kB	300.0kB	+5kB🚨
/blog/[url]	1.6kB	2.1kB	0.5kB	296kB	300.0kB	+4kB⚠️
/blog/page/[page]	0.8kB	1.5kB	0.7kB	295kB	300.0kB	+5kB🚨
/blog/tagged/[url]	1.6kB	2.2kB	0.6kB	296kB	300.0kB	+4kB⚠️
/c/[...url]	3.2kB	3.2kB		318kB	322.0kB	+4kB⚠️
/cart	3.6kB	2.9kB	-0.7kB	306kB	313.0kB	+7kB🚨
/checkout	8.6kB	8.9kB	0.3kB	277kB	278.0kB	+1kB⚠️
/checkout/added	5.6kB	5.9kB	0.3kB	255kB	258.0kB	+3kB⚠️
/checkout/customer/addresses/edit	5.8kB	5.7kB	-0.1kB	272kB	273.0kB	+1kB⚠️
/checkout/edit/billing-address	3.2kB	3.0kB	-0.2kB	267kB	268.0kB	+1kB⚠️
/checkout/payment	13.8kB	14.1kB	0.3kB	292kB	293.0kB	+1kB⚠️
/checkout/success	5.4kB	6.5kB	+1.1kB⚠️	283kB	284.0kB	+1kB⚠️
/compare	9.5kB	9.5kB		284kB	287.0kB	+3kB⚠️
/customer/account/createPassword	7.1kB	7.1kB		263kB	264.0kB	+1kB⚠️
/modal/[...url]	6.2kB	6.2kB		274kB	277.0kB	+3kB⚠️
/newsletter	6.4kB	6.4kB		299kB	302.0kB	+3kB⚠️
/p/[url]	21.7kB	20.1kB	-1.6kB	337kB	341.0kB	+4kB⚠️
/products-sitemap.xml	0.3kB	0.3kB		192kB	193.0kB	+1kB⚠️
/search	4.3kB	4.3kB		325kB	330.0kB	+5kB🚨
/search/[...url]	4.3kB	4.3kB		325kB	330.0kB	+5kB🚨
/service/[[...url]]	6.1kB	6.1kB		274kB	277.0kB	+3kB⚠️
/switch-stores	7.3kB	7.3kB		226kB	227.0kB	+1kB⚠️
/test/[[...url]]	4.4kB	4.9kB	0.5kB	247kB	249.0kB	+2kB⚠️
/test/icons	4.7kB	4.9kB	0.2kB	225kB	225.0kB
/test/minimal-page-shell/[[...url]]	6.0kB	6.0kB		219kB	220.0kB	+1kB⚠️
/test/slider	7.0kB	7.5kB	0.5kB	249kB	252.0kB	+3kB⚠️
/test/usebacklink/[[...url]]	3.8kB	3.8kB		210kB	211.0kB	+1kB⚠️
/wishlist	7.3kB	7.1kB	-0.2kB	277kB	280.0kB	+3kB⚠️

…art.

github-actions · 2024-03-27T11:36:01Z

Page	Size old	Size new	Size diff	First load old	First load new	First load diff
/	3.1kB	3.5kB	0.4kB	294kB	299.0kB	+5kB🚨
/[...url]	3.2kB	3.2kB		318kB	323.0kB	+5kB🚨
/404	6.0kB	6.3kB	0.3kB	241kB	247.0kB	+6kB🚨
/account	10.6kB	10.6kB		246kB	247.0kB	+1kB⚠️
/account/addresses/add	7.6kB	7.6kB		271kB	272.0kB	+1kB⚠️
/account/authentication	7.6kB	7.6kB		268kB	269.0kB	+1kB⚠️
/account/contact	7.8kB	7.8kB		268kB	269.0kB	+1kB⚠️
/account/forgot-password	5.2kB	5.2kB		261kB	262.0kB	+1kB⚠️
/account/orders	7.2kB	7.2kB		246kB	247.0kB	+1kB⚠️
/account/reviews/add	7.4kB	7.4kB		266kB	267.0kB	+1kB⚠️
/blog	0.8kB	1.5kB	0.7kB	295kB	300.0kB	+5kB🚨
/blog/[url]	1.6kB	2.1kB	0.5kB	296kB	300.0kB	+4kB⚠️
/blog/page/[page]	0.8kB	1.5kB	0.7kB	295kB	300.0kB	+5kB🚨
/blog/tagged/[url]	1.6kB	2.2kB	0.6kB	296kB	301.0kB	+5kB🚨
/c/[...url]	3.2kB	3.2kB		318kB	323.0kB	+5kB🚨
/cart	3.6kB	2.9kB	-0.7kB	306kB	313.0kB	+7kB🚨
/checkout	8.6kB	9.1kB	0.5kB	277kB	278.0kB	+1kB⚠️
/checkout/added	5.6kB	5.9kB	0.3kB	255kB	258.0kB	+3kB⚠️
/checkout/customer/addresses/edit	5.8kB	5.7kB	-0.1kB	272kB	273.0kB	+1kB⚠️
/checkout/edit/billing-address	3.2kB	3.0kB	-0.2kB	267kB	267.0kB
/checkout/payment	13.8kB	14.1kB	0.3kB	292kB	292.0kB
/checkout/success	5.4kB	6.5kB	+1.1kB⚠️	283kB	284.0kB	+1kB⚠️
/compare	9.5kB	9.5kB		284kB	288.0kB	+4kB⚠️
/modal/[...url]	6.2kB	6.2kB		274kB	278.0kB	+4kB⚠️
/newsletter	6.4kB	6.4kB		299kB	303.0kB	+4kB⚠️
/p/[url]	21.7kB	20.1kB	-1.6kB	337kB	341.0kB	+4kB⚠️
/search	4.3kB	4.3kB		325kB	330.0kB	+5kB🚨
/search/[...url]	4.3kB	4.3kB		325kB	330.0kB	+5kB🚨
/service/[[...url]]	6.1kB	6.1kB		274kB	278.0kB	+4kB⚠️
/test/[[...url]]	4.4kB	5.1kB	0.7kB	247kB	249.0kB	+2kB⚠️
/test/icons	4.7kB	4.9kB	0.2kB	225kB	225.0kB
/test/slider	7.0kB	7.7kB	0.7kB	249kB	252.0kB	+3kB⚠️
/wishlist	7.3kB	7.1kB	-0.2kB	277kB	280.0kB	+3kB⚠️

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 4, 2024 11:38 View deployment

vercel bot deployed to Preview – graphcommerce January 4, 2024 11:42 View deployment

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 8, 2024 13:23 View deployment

vercel bot deployed to Preview – graphcommerce January 8, 2024 13:25 View deployment

vercel bot had a problem deploying to Preview – graphcommerce January 8, 2024 13:57 Failure

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 8, 2024 13:58 View deployment

vercel bot had a problem deploying to Preview – graphcommerce January 8, 2024 13:59 Failure

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 8, 2024 13:59 View deployment

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 8, 2024 16:08 View deployment

vercel bot deployed to Preview – graphcommerce January 8, 2024 16:10 View deployment

paales changed the title ~~Feature/gcom 1312~~ Refactor GA4 / GTM tracking preferences (GCOM-1312) Jan 15, 2024

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui February 19, 2024 12:45 View deployment

vercel bot had a problem deploying to Preview – graphcommerce February 19, 2024 12:46 Failure

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui February 19, 2024 13:32 View deployment

vercel bot had a problem deploying to Preview – graphcommerce February 19, 2024 13:33 Failure

paales requested changes Mar 21, 2024

View reviewed changes

paales marked this pull request as ready for review March 21, 2024 14:06

mikekeehnen added 2 commits March 26, 2024 09:44

[GCOM-1312]: Added events to GTM package

0032a67

[GCOM-1312] feat: Added GTM events to package

2e79d8c

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 26, 2024 08:44 View deployment

mikekeehnen added 3 commits March 26, 2024 09:44

[GCOM-1312] chore: Remove old GA4 and GTM events

77c6bdc

[GCOM-1312] feat: Add new GC analytics package with all supported events

3383cdf

[GCOM-1312] chore: Update dependencies in google packages

db88058

vercel bot deployed to Preview – graphcommerce March 26, 2024 08:47 View deployment

mikekeehnen and others added 3 commits March 26, 2024 09:47

[GCOM-1312] feat: Add config values to analytics package

b56d4ed

[GCOM-1312] chore: Cleanup package.json's

02dc9a2

Coupon code is expected to be a string

ed30a97

Added debugging statements

2feafb8

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 26, 2024 13:23 View deployment

vercel bot deployed to Preview – graphcommerce March 26, 2024 13:25 View deployment

paales added 2 commits March 26, 2024 14:31

Always enable the datalayer

695b176

Fix UpdateItemQuantity

5146f5d

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 26, 2024 13:32 View deployment

vercel bot had a problem deploying to Preview – graphcommerce March 26, 2024 13:32 Failure

Added changeset and prevented plugin collisions

34de808

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 26, 2024 14:26 View deployment

vercel bot deployed to Preview – graphcommerce March 26, 2024 14:28 View deployment

This comment was marked as outdated.

Sign in to view

Fix addToCart metric

8d33b5e

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 26, 2024 15:10 View deployment

vercel bot deployed to Preview – graphcommerce March 26, 2024 15:12 View deployment

paales added 2 commits March 27, 2024 12:01

Disable broken pageview event

944ad1f

Created a new findAddedItems utility to find the items added to the c…

b301014

…art.

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 27, 2024 11:07 View deployment

vercel bot had a problem deploying to Preview – graphcommerce March 27, 2024 11:07 Failure

Cleanup logs

9017bcd

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 27, 2024 11:16 View deployment

vercel bot had a problem deploying to Preview – graphcommerce March 27, 2024 11:16 Failure

Fix build

429616c

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui March 27, 2024 11:29 View deployment

vercel bot deployed to Preview – graphcommerce March 27, 2024 11:31 View deployment

paales merged commit 4194be6 into canary Mar 27, 2024
4 checks passed

paales deleted the feature/GCOM-1312 branch March 27, 2024 13:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor GA4 / GTM tracking preferences (GCOM-1312) #2158

Refactor GA4 / GTM tracking preferences (GCOM-1312) #2158

mikekeehnen commented Jan 4, 2024

changeset-bot bot commented Jan 4, 2024 •

edited

Loading

vercel bot commented Jan 4, 2024 •

edited

Loading

Giovanni-Schroevers commented Feb 23, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

This comment was marked as outdated.

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 27, 2024

Refactor GA4 / GTM tracking preferences (GCOM-1312) #2158

Refactor GA4 / GTM tracking preferences (GCOM-1312) #2158

Conversation

mikekeehnen commented Jan 4, 2024

changeset-bot bot commented Jan 4, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jan 4, 2024 • edited Loading

Giovanni-Schroevers commented Feb 23, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

This comment was marked as outdated.

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 27, 2024

changeset-bot bot commented Jan 4, 2024 •

edited

Loading

vercel bot commented Jan 4, 2024 •

edited

Loading