feat(GCOM-1318): dismiss login page and go back to previous page asap when logging in #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 967dcdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
1 similar comment
|
paales
force-pushed
the
feature/GCOM-1318
branch
from
048a007 to
2eca9da
Compare
|
paales
force-pushed
the
feature/GCOM-1318
branch
from
fd97f79 to
967dcdd
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty bare-bones right now. It just logs you in and returns you to the previous page.
It feels pretty frictionless to me, but might be lacking in feedback a little bit?
Having a sceen with "You're now logg in. [Continue shopping]" is clear but does not really add much either.
Redirecting to the account page after logging in also feels pretty silly.
This might be one of those things that feels unnatural at first, but I think it provides value by effortlessly continuing what you were doing before logging in. Therefore it might feel right pretty fast.
Thanks for reading this long essay about a trivial issue, have a great day!