Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Bakery issues WONTFIX documentation: #3

Open
graphicore opened this issue Jul 12, 2017 · 3 comments
Open

Font Bakery issues WONTFIX documentation: #3

graphicore opened this issue Jul 12, 2017 · 3 comments

Comments

@graphicore
Copy link
Owner

graphicore commented Jul 12, 2017

Does GPOS table have kerning information?

  • ERROR: Font is missing a "GPOS" table

These fonts don't require any kerning.

fontforge-check: Font doesn't have invalid glyph names

  • ERROR: fontforge-check: Font has invalid glyph names!

There are invalid glyph names, but these are never exposed to the layout directly. These are glyphs used as components. names are:

  • below-uniXXXX for glyphs below
  • code-{description} for the raw barcode glyphs

Font has 'EURO SIGN' character?

  • ERROR: Font lacks the 'EURO SIGN' character.

Not encoded in neither 39 nor 128

Whitespace glyphs have ink?

  • ERROR: Glyph "uni0020" has ink. It needs to be replaced by an empty glyph
  • ERROR: Glyph "uni00A0" has ink. It needs to be replaced by an empty glyph

space is a symbol in our barcodes, does it needs bars.

Checking if the font is truly monospaced

  • ERROR: Font is monospaced but 11 glyphs (11.9565217391%) have a different width. You should check the widths of: ['code-percent', 'code-slash', 'uni002B', 'uni002F', 'uni0025', 'uni0024', 'uni000D', 'code-dollar', 'uni0000', 'code-plus'] Changes that must be applied to this font: post isFixedPitch from 0 to 1 | OS/2 panose.bProportion from 0 to 9

This test is basically guessing and the fonts are unusual. The fonts are not monospaced.

fontforge-check: Glyphs have points at extremas

  • ERROR: fontforge-check: Glyphs do not have points at extremas!

This applies to barcode fonts with font below. I assume that either the fontmake pipeline adds some none extremas, where TTF outlines have implicit oncurve points or that the used font has this kind of outlines. We could look into improving this situation in the pipeline.

@davelab6
Copy link
Contributor

davelab6 commented Jul 12, 2017

  • ERROR: fontforge-check: Font has invalid glyph names!

Hmm. Maybe we should make that a WARN for our purposes, in general...

In any case, I guess we need to add these font filenames to the FB whitelist so FB passes them... ;)

@davelab6
Copy link
Contributor

I think this is good to have in the issue tracker for search indexing, but is better to put in the README in a 'caveats' section.

@davelab6
Copy link
Contributor

Would you invite me to the repo as an owner, and then I can get your markdown out of the issue and make a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants