Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows a user to create a version of the plugin that resolves entities according to how they'd like. This should allow users to write a version of the plugin that uses primary keys as fields for the
@key
directive without running into the concerns mentioned in #1 (comment). The existing version of the plugin, usingnodeId
, is created this way and exported as the default. It's not too friendly or intuitive, so, if this is an acceptable direction, I would appreciate input on how to make it more usable.Performance impact
I have not noticed any performance impact. After schema construction, it shouldn't be any slower than it was before.
Security impact
I am not aware of any risks added, though the new way of handling the
@key
directive may run into something I have not seen.Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).