Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makeFederationSchemaPlugin. #19

Closed
wants to merge 1 commit into from
Closed

Add makeFederationSchemaPlugin. #19

wants to merge 1 commit into from

Conversation

wtgtybhertgeghgtwtg
Copy link

Description

This allows a user to create a version of the plugin that resolves entities according to how they'd like. This should allow users to write a version of the plugin that uses primary keys as fields for the @key directive without running into the concerns mentioned in #1 (comment). The existing version of the plugin, using nodeId, is created this way and exported as the default. It's not too friendly or intuitive, so, if this is an acceptable direction, I would appreciate input on how to make it more usable.

Performance impact

I have not noticed any performance impact. After schema construction, it shouldn't be any slower than it was before.

Security impact

I am not aware of any risks added, though the new way of handling the @key directive may run into something I have not seen.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@benjie
Copy link
Member

benjie commented Jan 5, 2021

I don't have time currently to review this; may I suggest that you maintain a fork and that we link to that fork from the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants