Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs for custom env #41

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Improved docs for custom env #41

merged 5 commits into from
Oct 28, 2024

Conversation

mj3cheun
Copy link
Contributor

No description provided.

@mj3cheun mj3cheun requested a review from DataBoyTX June 10, 2024 19:15
@lmeyerov
Copy link
Contributor

@aucahuasi can you help resolve the conflict on telemetry.md ?

@@ -38,7 +38,6 @@ For example, this is the configuration template for a local development env that
```bash
ENABLE_OPEN_TELEMETRY=true

OTEL_COLLECTOR_OTLP_HTTP_ENDPOINT="https://hostname.grafana.net/otlp" # e.g. Grafana OTLP HTTP endpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mj3cheun I think I may have lost this in the mere, and don't know what the right thing to do here, can you check in case a new PR needed to reintroduce?

(pushing updates in a few sec)

@lmeyerov lmeyerov merged commit 921a7ab into master Oct 28, 2024
4 checks passed
@lmeyerov lmeyerov deleted the doc-for-custom-env branch October 28, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants