Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use workaround for jsdocs parsing issues #160

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

mj3cheun
Copy link
Contributor

@mj3cheun mj3cheun commented Mar 20, 2024

image

@mj3cheun mj3cheun requested a review from lmeyerov March 20, 2024 23:48
Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- changelog and start the release flow? I forgot if we got you into the npm org + release flow yet

fwiw... should CI have prevented the prev versions from going through? or it appears as just undocumented bits, not actual errors

@mj3cheun
Copy link
Contributor Author

mj3cheun commented Mar 21, 2024

changelog updated. will do release for 5.1.1 under a 5.1.1 branch. you added me to the npm org and walked me through the release flow, ill let you know if i come up with any problems.

CI would not have caught this, no errors were thrown. there were some undocumented classes but that wasn't the problem, its just that because jsdocs was parsing the comments wrong there is documentation that its skipping over and therefore not generating.

@mj3cheun mj3cheun merged commit 3eee37a into master Mar 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants