fix STATIC_ROOT not used for dashboard theme search (Fix #2683, #1702) #2816
Conversation
|
Hi @niol |
|
Hm, tests are obviously broken because of change Not shure what is System check though... |
|
Found https://stackoverflow.com/questions/68248861/staticfiles-e002-error-the-staticfiles-dirs-setting-should-not-contain-the but I'm currently AFK to properly address this. @niol , could you please check? |
|
Cool, tests are passing, will merge that. (Deepsource is failing, but it's too strict, we can skip it). Thanks for your contribution! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| css_file = os.path.isfile(os.path.join(settings.STATIC_ROOT, | ||
| 'css/dashboard-%s.css' % theme)) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
- Coverage 76.36% 76.33% -0.03%
==========================================
Files 88 88
Lines 9683 9686 +3
Branches 2066 2067 +1
==========================================
Hits 7394 7394
- Misses 2024 2026 +2
- Partials 265 266 +1
☔ View full report in Codecov by Sentry. |
No description provided.