Merge pull request #268 from richmolj/update_scope

Ensure scope override is honored on update/destroy

lib/graphiti/resource_proxy.rb

@@ -118,6 +118,7 @@ def save(action: :create)
     end
 
     def destroy
+      data
       transaction_response = @resource.transaction do
         metadata = {method: :destroy}
         model = @resource.destroy(@query.filters[:id], metadata)
@@ -135,6 +136,7 @@ def destroy
     end
 
     def update_attributes
+      data
       save(action: :update)
     end
 

lib/graphiti/version.rb

@@ -1,3 +1,3 @@
 module Graphiti
-  VERSION = "1.2.21"
+  VERSION = "1.2.22"
 end

spec/persistence_spec.rb

@@ -32,6 +32,40 @@ def self.name
     expect(employee.data.first_name).to eq("Jane")
   end
 
+  describe 'updating' do
+    let!(:employee) { PORO::Employee.create(first_name: 'asdf') }
+
+    before do
+      payload[:data][:id] = employee.id.to_s
+    end
+
+    describe 'with scope override' do
+      it 'is honored' do
+        employee = klass.find(payload, { type: 'foo' })
+        expect {
+          employee.update_attributes
+        }.to raise_error(Graphiti::Errors::RecordNotFound)
+      end
+    end
+  end
+
+  describe 'destroying' do
+    let!(:employee) { PORO::Employee.create(first_name: 'asdf') }
+
+    before do
+      payload[:data][:id] = employee.id.to_s
+    end
+
+    describe 'with scope override' do
+      it 'is honored' do
+        employee = klass.find(payload, { type: 'foo' })
+        expect {
+          employee.destroy
+        }.to raise_error(Graphiti::Errors::RecordNotFound)
+      end
+    end
+  end
+
   describe "overrides" do
     before do
       klass.class_eval do